usecases/cli:chore - remove unnecessary UseCases struct #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
This commit remove an unnecessary empty `UseCases` struct and change
their methods to functions and change the references to this struct to
call the public function directly.
Some private functions from this package was renamed to have consistency
between all of them.
Removing this struct we also remove an unnecessary heap allocation since
the `NewCLIUseCases()` function return a pointer to this struct.
The heap allocation was noticed using the
github.com/jordanlewis/gcassert using the `gcassert:noescape` directive
on cmd/app/start/start.go:68:
```
gcassert ./cmd/app/start/
cmd/app/start/start.go:75:useCases: cli.NewCLIUseCases(): &cli.UseCases{} escapes to heap:
```
Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
remove-usecases-struct
branch
from
2e2dbb7 to
7357667
Compare
nathanmartinszup
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove an unnecessary empty
UseCasesstruct and changetheir methods to functions and change the references to this struct to
call the public function directly.
Some private functions from this package was renamed to have consistency
between all of them.
Removing this struct we also remove an unnecessary heap allocation since
the
NewCLIUseCases()function return a pointer to this struct.The heap allocation was noticed using the
github.com/jordanlewis/gcassert using the
gcassert:noescapedirectiveon cmd/app/start/start.go:68:
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog