workdir:chore - improve tests and rename public functions #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
workdir-tests
branch
2 times, most recently
from
3232a63 to
10983a4
Compare
This commit improve the current tests and add new ones. The improvement was made to have a better assertiveness and cover more scenarios. The public functions `NewWorkDir` and `ParseInterfaceToStruct` was renamed to `Default` and `MustParseWorkDir` respectively to follow the same API from toolsconfig and customimages packages to have consistency between them. This commit also remove the unused method `Type` from WorkDir struct. Updates #718 Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
workdir-tests
branch
from
10983a4 to
8ab857c
Compare
iancardosozup
approved these changes
Nov 18, 2021
nathanmartinszup
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improve the current tests and add new ones. The improvement
was made to have a better assertiveness and cover more scenarios.
The public functions
NewWorkDirandParseInterfaceToStructwasrenamed to
DefaultandMustParseWorkDirrespectively to follow thesame API from toolsconfig and customimages packages to have consistency
between them.
This commit also remove the unused method
Typefrom WorkDir struct.Updates #718
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog