e2e:chore - tests for risk accepted and false positive flags #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbrunozup
requested review from
iancardosozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
lucasbrunozup
commented
Nov 16, 2021
lucasbrunozup
force-pushed
the
feat/e2e-risk-accepted-false-positive
branch
2 times, most recently
from
62ac2df to
b0690a4
Compare
|
With each analysis on Windows, the vulnerability hash is different, I need help to identify the cause or define it as a bug. |
lucasbrunozup
force-pushed
the
feat/e2e-risk-accepted-false-positive
branch
from
b0690a4 to
5c2afec
Compare
lucasbrunozup
force-pushed
the
feat/e2e-risk-accepted-false-positive
branch
2 times, most recently
from
beab605 to
2878b64
Compare
matheusalcantarazup
added a commit
that referenced
this pull request
Nov 17, 2021
Previously when running the Horusec on Windows we was getting a different vulnerability hash for each analysis, this problem was happening because we weren't removing the .horusec folder from the file path before generating the hash, and since the .horusec folder contains a uuid, on every analysis we was getting a new uuid and consequently a new vulnerability hash. The commit fix this issue using a better approach to remove the .horusec folder from filepath, using the relative path from file using the .horusec folder as base path. This commit also change the testcase to catch this bug. This bug was founded on #777 Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
added a commit
that referenced
this pull request
Nov 17, 2021
Previously when running the Horusec on Windows we was getting a different vulnerability hash for each analysis, this problem was happening because we weren't removing the .horusec folder from the file path before generating the hash, and since the .horusec folder contains a uuid, on every analysis we was getting a new uuid and consequently a new vulnerability hash. The commit fix this issue using a better approach to remove the .horusec folder from filepath, using the relative path from file using the .horusec folder as base path. This commit also change the testcase to catch this bug. This bug was founded on #777 Signed-off-by: Matheus Alcantara <[email protected]>
Signed-off-by: lucas.bruno <[email protected]>
lucasbrunozup
force-pushed
the
feat/e2e-risk-accepted-false-positive
branch
from
2878b64 to
5755b23
Compare
matheusalcantarazup
approved these changes
Nov 17, 2021
matheusalcantarazup
deleted the
feat/e2e-risk-accepted-false-positive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests e2e for risk accepted and false positive flags.
Signed-off-by: lucas.bruno [email protected]