Fix some tests validation and usecases #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiliansilvazup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
nathanmartinszup
as code owners
wiliansilvazup
force-pushed
the
fix/cli-usecase
branch
from
9439ec2 to
96690db
Compare
wiliansilvazup
force-pushed
the
fix/cli-usecase
branch
from
96690db to
87b303d
Compare
wiliansilvazup
changed the title
matheusalcantarazup
suggested changes
Nov 4, 2021
In usecases we have validation for check absolute path of the output file, but is not create any validation, also i removed this code and fix your tests. Other implementation was fix output file path in tests of package start and tests of package language_detect. Signed-off-by: wilian <[email protected]>
wiliansilvazup
force-pushed
the
fix/cli-usecase
branch
from
87b303d to
426c42a
Compare
matheusalcantarazup
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wilian [email protected]