Refactoring the e2e scans tests #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbrunozup
requested review from
iancardosozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
lucasbrunozup
force-pushed
the
feat/e2e-analysis
branch
from
9247c33 to
7726512
Compare
matheusalcantarazup
suggested changes
Nov 3, 2021
lucasbrunozup
force-pushed
the
feat/e2e-analysis
branch
from
7726512 to
fa2a016
Compare
lucasbrunozup
force-pushed
the
feat/e2e-analysis
branch
3 times, most recently
from
efb9398 to
b99a2f5
Compare
Signed-off-by: lucas.bruno <[email protected]>
lucasbrunozup
force-pushed
the
feat/e2e-analysis
branch
from
b99a2f5 to
f58a32e
Compare
iancardosozup
approved these changes
Nov 4, 2021
nathanmartinszup
approved these changes
Nov 4, 2021
matheusalcantarazup
approved these changes
Nov 4, 2021
oliveirafelipezup
pushed a commit
that referenced
this pull request
Nov 4, 2021
Signed-off-by: lucas.bruno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Improved assertiveness of e2e analysis tests
- How to verify it
make test-e2eand expected all tests passedSigned-off-by: lucas.bruno [email protected]