config: fix read config file if its not default value #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
fix-config-file
branch
3 times, most recently
from
9a5e88b to
e8fc411
Compare
matheusalcantarazup
force-pushed
the
fix-config-file
branch
from
e8fc411 to
85115c6
Compare
iancardosozup
approved these changes
Oct 7, 2021
|
sync your pr with main to fix conflicts |
Previously we are reading the config file before parsing the command line flags, so, when a user pass a different path of config file we weren't read the file because we was trying to read on default value (that is the current working directory). This commit change to parse the values manually, so, we first parse global flags, them read the config file and environment variables and finally parse the start command flags. The changes on config/config.go is basically a rollback from changes made on pr #523. Issue: #656 Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
fix-config-file
branch
from
85115c6 to
fa7bbaf
Compare
wiliansilvazup
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we are reading the config file before parsing the command
line flags, so, when a user pass a different path of config
file we weren't read the file because we was trying to read on default
value (that is the current working directory). This commit change to
parse the values manually, so, we first parse global flags, them read the
config file and environment variables and finally parse the start command
flags. The changes on config/config.go is basically a rollback from changes
made on pr #523.
Issue: #656
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog