tests: refactor leaks tests to be more generic #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
engine-rules-tests
branch
2 times, most recently
from
499cff5 to
22aa3d1
Compare
iancardosozup
approved these changes
Oct 1, 2021
matheusalcantarazup
force-pushed
the
engine-rules-tests
branch
2 times, most recently
from
9e0db83 to
b2c932d
Compare
This commit refactor the tests of leaks rules to be more generic and be more easily to add new test cases. The leak tests was removed on PR #624. So this commit re-introduce the tests but with some improvements Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
engine-rules-tests
branch
from
b2c932d to
874707f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This commit refactor the tests of leaks rules to be more generic and be
more easily to add new test cases. The leak tests was removed on PR #624.
So this commit re-introduce the tests but with some improvements
Signed-off-by: Matheus Alcantara [email protected]
- How to verify it
- Description for the changelog