Skip to content

Commit ca562c5

Browse files
authored
feat: project field to feature removed event (#9322)
Start sending out project for feature deleted, as we need it for edge to keep exact copy.
1 parent c1fc07f commit ca562c5

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -205,17 +205,9 @@ export class ClientFeatureToggleDelta extends EventEmitter {
205205
return undefined;
206206
}
207207

208-
const response: ClientFeaturesDeltaSchema = {
209-
events: events.map((event) => {
210-
if (event.type === 'feature-removed') {
211-
const { project, ...rest } = event;
212-
return rest;
213-
}
214-
return event;
215-
}),
208+
return {
209+
events,
216210
};
217-
218-
return Promise.resolve(response);
219211
}
220212
}
221213

src/lib/features/client-feature-toggles/delta/delta-cache.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,13 @@ describe('RevisionCache', () => {
131131
},
132132
{
133133
eventId: 4,
134-
type: 'feature-removed',
134+
type: DELTA_EVENT_TYPES.FEATURE_REMOVED,
135135
featureName: 'test-flag',
136136
project: 'default',
137137
},
138138
{
139139
eventId: 5,
140-
type: 'segment-updated',
140+
type: DELTA_EVENT_TYPES.SEGMENT_UPDATED,
141141
segment: {
142142
id: 1,
143143
name: 'update-segment-new',
@@ -146,12 +146,12 @@ describe('RevisionCache', () => {
146146
},
147147
{
148148
eventId: 6,
149-
type: 'segment-removed',
149+
type: DELTA_EVENT_TYPES.SEGMENT_REMOVED,
150150
segmentId: 2,
151151
},
152152
{
153153
eventId: 7,
154-
type: 'segment-updated',
154+
type: DELTA_EVENT_TYPES.SEGMENT_UPDATED,
155155
segment: {
156156
id: 3,
157157
name: 'new-segment',

src/lib/openapi/spec/client-features-delta-schema.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ test('clientFeaturesDeltaSchema all fields', () => {
88
eventId: 1,
99
type: 'feature-removed',
1010
featureName: 'removed-event',
11+
project: 'default',
1112
},
1213
{
1314
eventId: 1,

src/lib/openapi/spec/client-features-delta-schema.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,12 @@ export const clientFeaturesDeltaSchema = {
3535
},
3636
{
3737
type: 'object',
38-
required: ['eventId', 'type', 'featureName'],
38+
required: ['eventId', 'type', 'featureName', 'project'],
3939
properties: {
4040
eventId: { type: 'number' },
4141
type: { type: 'string', enum: ['feature-removed'] },
4242
featureName: { type: 'string' },
43+
project: { type: 'string' },
4344
},
4445
},
4546
{

0 commit comments

Comments
 (0)