Skip to content

Commit af51653

Browse files
fix: return if empty array (#9254)
Fixes an issue where segment-updated event would be added to cache even though there were no correlated events. Tests needs to be added in Enterprise.
1 parent aa5c70f commit af51653

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
171171
if (!hasDelta) {
172172
await this.initEnvironmentDelta(environment);
173173
}
174+
174175
if (requiredRevisionId >= this.currentRevisionId) {
175176
return undefined;
176177
}
@@ -272,7 +273,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
272273
.map((event) => event.preData.id);
273274

274275
const segments =
275-
await this.segmentReadModel.getAllForClient(segmentsUpdated);
276+
await this.segmentReadModel.getAllForClientIds(segmentsUpdated);
276277

277278
const segmentsUpdatedEvents: DeltaEvent[] = segments.map((segment) => ({
278279
eventId: latestRevision,
@@ -328,7 +329,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
328329
const baseFeatures = await this.getClientFeatures({
329330
environment,
330331
});
331-
const baseSegments = await this.segmentReadModel.getAllForClient();
332+
const baseSegments = await this.segmentReadModel.getAllForClientIds();
332333

333334
this.currentRevisionId =
334335
await this.configurationRevisionService.getMaxRevisionId();

src/lib/features/segment/fake-segment-read-model.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class FakeSegmentReadModel implements ISegmentReadModel {
2323
return [];
2424
}
2525

26-
async getAllForClient(ids?: number[]): Promise<IClientSegment[]> {
26+
async getAllForClientIds(ids?: number[]): Promise<IClientSegment[]> {
2727
return [];
2828
}
2929
}

src/lib/features/segment/segment-read-model-type.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ export interface ISegmentReadModel {
99
getAllFeatureStrategySegments(): Promise<IFeatureStrategySegment[]>;
1010
getActive(): Promise<ISegment[]>;
1111
getActiveForClient(): Promise<IClientSegment[]>;
12-
getAllForClient(ids?: number[]): Promise<IClientSegment[]>;
12+
getAllForClientIds(ids?: number[]): Promise<IClientSegment[]>;
1313
}

src/lib/features/segment/segment-read-model.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,11 @@ export class SegmentReadModel implements ISegmentReadModel {
110110
}));
111111
}
112112

113-
async getAllForClient(ids?: number[]): Promise<IClientSegment[]> {
113+
async getAllForClientIds(ids?: number[]): Promise<IClientSegment[]> {
114+
if (!ids || ids.length === 0) {
115+
return [];
116+
}
117+
114118
const fullSegments = await this.getAll(ids);
115119

116120
return fullSegments.map((segments) => ({

0 commit comments

Comments
 (0)