Commit af51653 1 parent aa5c70f commit af51653 Copy full SHA for af51653
File tree 4 files changed +10
-5
lines changed
client-feature-toggles/delta
4 files changed +10
-5
lines changed Original file line number Diff line number Diff line change @@ -171,6 +171,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
171
171
if ( ! hasDelta ) {
172
172
await this . initEnvironmentDelta ( environment ) ;
173
173
}
174
+
174
175
if ( requiredRevisionId >= this . currentRevisionId ) {
175
176
return undefined ;
176
177
}
@@ -272,7 +273,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
272
273
. map ( ( event ) => event . preData . id ) ;
273
274
274
275
const segments =
275
- await this . segmentReadModel . getAllForClient ( segmentsUpdated ) ;
276
+ await this . segmentReadModel . getAllForClientIds ( segmentsUpdated ) ;
276
277
277
278
const segmentsUpdatedEvents : DeltaEvent [ ] = segments . map ( ( segment ) => ( {
278
279
eventId : latestRevision ,
@@ -328,7 +329,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
328
329
const baseFeatures = await this . getClientFeatures ( {
329
330
environment,
330
331
} ) ;
331
- const baseSegments = await this . segmentReadModel . getAllForClient ( ) ;
332
+ const baseSegments = await this . segmentReadModel . getAllForClientIds ( ) ;
332
333
333
334
this . currentRevisionId =
334
335
await this . configurationRevisionService . getMaxRevisionId ( ) ;
Original file line number Diff line number Diff line change @@ -23,7 +23,7 @@ export class FakeSegmentReadModel implements ISegmentReadModel {
23
23
return [ ] ;
24
24
}
25
25
26
- async getAllForClient ( ids ?: number [ ] ) : Promise < IClientSegment [ ] > {
26
+ async getAllForClientIds ( ids ?: number [ ] ) : Promise < IClientSegment [ ] > {
27
27
return [ ] ;
28
28
}
29
29
}
Original file line number Diff line number Diff line change @@ -9,5 +9,5 @@ export interface ISegmentReadModel {
9
9
getAllFeatureStrategySegments ( ) : Promise < IFeatureStrategySegment [ ] > ;
10
10
getActive ( ) : Promise < ISegment [ ] > ;
11
11
getActiveForClient ( ) : Promise < IClientSegment [ ] > ;
12
- getAllForClient ( ids ?: number [ ] ) : Promise < IClientSegment [ ] > ;
12
+ getAllForClientIds ( ids ?: number [ ] ) : Promise < IClientSegment [ ] > ;
13
13
}
Original file line number Diff line number Diff line change @@ -110,7 +110,11 @@ export class SegmentReadModel implements ISegmentReadModel {
110
110
} ) ) ;
111
111
}
112
112
113
- async getAllForClient ( ids ?: number [ ] ) : Promise < IClientSegment [ ] > {
113
+ async getAllForClientIds ( ids ?: number [ ] ) : Promise < IClientSegment [ ] > {
114
+ if ( ! ids || ids . length === 0 ) {
115
+ return [ ] ;
116
+ }
117
+
114
118
const fullSegments = await this . getAll ( ids ) ;
115
119
116
120
return fullSegments . map ( ( segments ) => ( {
You can’t perform that action at this time.
0 commit comments