chore: deprecate and undeprecate protected environments (#9360)

https://linear.app/unleash/issue/2-3320/allow-users-to-deprecate-and-undeprecate-protected-environments

Allows users to deprecate and undeprecate protected environments.


![image](https://github.com/user-attachments/assets/621684d3-21e3-4f58-b6b5-2d2731c9fd9e)

Author: nunogois

frontend/src/component/environments/EnvironmentTable/EnvironmentActionCell/EnvironmentActionCellPopover/EnvironmentActionCellPopover.tsx

@@ -140,7 +140,7 @@ export const EnvironmentActionCellPopover = ({
                                     onDeprecateToggle();
                                     handleClose();
                                 }}
-                                disabled={!hasAccess || environment.protected}
+                                disabled={!hasAccess}
                             >
                                 <ListItemIcon>
                                     <ConditionallyRender

src/lib/features/project-environments/environment-service.ts

@@ -94,7 +94,7 @@ export default class EnvironmentService {
     async toggleEnvironment(name: string, value: boolean): Promise<void> {
         const exists = await this.environmentStore.exists(name);
         if (exists) {
-            return this.environmentStore.updateProperty(name, 'enabled', value);
+            return this.environmentStore.toggle(name, value);
         }
         throw new NotFoundError(`Could not find environment ${name}`);
     }

src/lib/features/project-environments/environment-store-type.ts

@@ -17,6 +17,7 @@ export interface IEnvironmentStore extends Store<IEnvironment, string> {
         field: string,
         value: string | number | boolean,
     ): Promise<void>;
+    toggle(name: string, enabled: boolean): Promise<void>;
     updateSortOrder(id: string, value: number): Promise<void>;
     importEnvironments(environments: IEnvironment[]): Promise<IEnvironment[]>;
     delete(name: string): Promise<void>;

src/lib/features/project-environments/environment-store.ts

@@ -309,6 +309,14 @@ export default class EnvironmentStore implements IEnvironmentStore {
             .where({ name: id });
     }
 
+    async toggle(name: string, enabled: boolean): Promise<void> {
+        await this.db(TABLE)
+            .update({
+                enabled,
+            })
+            .where({ name });
+    }
+
     async update(
         env: Pick<IEnvironment, 'type' | 'protected'>,
         name: string,

src/lib/features/project-environments/fake-environment-store.ts

@@ -92,6 +92,14 @@ export default class FakeEnvironmentStore implements IEnvironmentStore {
         return Promise.resolve();
     }
 
+    async toggle(name: string, enabled: boolean): Promise<void> {
+        const environment = this.environments.find(
+            (env: IEnvironment) => env.name === name,
+        );
+        if (environment) environment.enabled = enabled;
+        return Promise.resolve();
+    }
+
     async connectProject(
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         environment: string,

src/test/e2e/api/admin/environment.test.ts

@@ -159,3 +159,12 @@ test('Getting a non existing environment yields 404', async () => {
         .get('/api/admin/environments/this-does-not-exist')
         .expect(404);
 });
+
+test('Can deprecate and undeprecate protected environments', async () => {
+    await app.request
+        .post(`/api/admin/environments/${DEFAULT_ENV}/off`)
+        .expect(204);
+    await app.request
+        .post(`/api/admin/environments/${DEFAULT_ENV}/on`)
+        .expect(204);
+});