chore: remove lifecycle v2 flag (#9224)

Author: Tymek

frontend/src/assets/icons/lifecycle/stage-5.svg frontend/src/assets/icons/lifecycle/stage-archived.svg

@@ -1,47 +1,25 @@
 import type { FC } from 'react';
-import { ReactComponent as InitialStageIcon } from 'assets/icons/stage-initial.svg';
-import { ReactComponent as PreLiveStageIcon } from 'assets/icons/stage-pre-live.svg';
-import { ReactComponent as LiveStageIcon } from 'assets/icons/stage-live.svg';
-import { ReactComponent as CompletedStageIcon } from 'assets/icons/stage-completed.svg';
-import { ReactComponent as ArchivedStageIcon } from 'assets/icons/stage-archived.svg';
-import { ReactComponent as Stage1 } from 'assets/icons/lifecycle/stage-1.svg';
-import { ReactComponent as Stage2 } from 'assets/icons/lifecycle/stage-2.svg';
-import { ReactComponent as Stage3 } from 'assets/icons/lifecycle/stage-3.svg';
-import { ReactComponent as Stage4 } from 'assets/icons/lifecycle/stage-4.svg';
-import { ReactComponent as Stage5 } from 'assets/icons/lifecycle/stage-5.svg';
+import { ReactComponent as CreatedIcon } from 'assets/icons/lifecycle/stage-created.svg';
+import { ReactComponent as PreLiveIcon } from 'assets/icons/lifecycle/stage-prelive.svg';
+import { ReactComponent as LiveIcon } from 'assets/icons/lifecycle/stage-live.svg';
+import { ReactComponent as CompletedIcon } from 'assets/icons/lifecycle/stage-completed.svg';
+import { ReactComponent as ArchivedIcon } from 'assets/icons/lifecycle/stage-archived.svg';
 import type { LifecycleStage } from '../../feature/FeatureView/FeatureOverview/FeatureLifecycle/LifecycleStage';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 export const FeatureLifecycleStageIcon: FC<{
     stage: Pick<LifecycleStage, 'name'>;
 }> = ({ stage, ...props }) => {
-    const newIcons = useUiFlag('lifecycleImprovements');
-
     if (stage.name === 'archived') {
-        return newIcons ? (
-            <Stage5 {...props} />
-        ) : (
-            <ArchivedStageIcon {...props} />
-        );
-    } else if (stage.name === 'pre-live') {
-        return newIcons ? (
-            <Stage2 {...props} />
-        ) : (
-            <PreLiveStageIcon {...props} />
-        );
-    } else if (stage.name === 'live') {
-        return newIcons ? <Stage3 {...props} /> : <LiveStageIcon {...props} />;
-    } else if (stage.name === 'completed') {
-        return newIcons ? (
-            <Stage4 {...props} />
-        ) : (
-            <CompletedStageIcon {...props} />
-        );
-    } else {
-        return newIcons ? (
-            <Stage1 {...props} />
-        ) : (
-            <InitialStageIcon {...props} />
-        );
+        return <ArchivedIcon {...props} />;
+    }
+    if (stage.name === 'pre-live') {
+        return <PreLiveIcon {...props} />;
+    }
+    if (stage.name === 'live') {
+        return <LiveIcon {...props} />;
+    }
+    if (stage.name === 'completed') {
+        return <CompletedIcon {...props} />;
     }
+    return <CreatedIcon {...props} />;
 };

frontend/src/assets/icons/lifecycle/stage-4.svg frontend/src/assets/icons/lifecycle/stage-completed.svg

@@ -1,12 +1,10 @@
 import { FeatureLifecycleStageIcon } from 'component/common/FeatureLifecycle/FeatureLifecycleStageIcon';
-import { FeatureLifecycleTooltip as LegacyFeatureLifecycleTooltip } from './LegacyFeatureLifecycleTooltip';
 import { FeatureLifecycleTooltip } from './FeatureLifecycleTooltip';
 import useFeatureLifecycleApi from 'hooks/api/actions/useFeatureLifecycleApi/useFeatureLifecycleApi';
 import { populateCurrentStage } from './populateCurrentStage';
 import type { FC } from 'react';
 import type { Lifecycle } from 'interfaces/featureToggle';
 import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 export interface LifecycleFeature {
     lifecycle?: Lifecycle;
@@ -29,7 +27,6 @@ export const FeatureLifecycle: FC<{
     const currentStage = populateCurrentStage(feature);
     const { markFeatureUncompleted, loading } = useFeatureLifecycleApi();
     const { trackEvent } = usePlausibleTracker();
-    const isLifecycleImprovementsEnabled = useUiFlag('lifecycleImprovements');
 
     const onUncompleteHandler = async () => {
         await markFeatureUncompleted(feature.name, feature.project);
@@ -41,23 +38,8 @@ export const FeatureLifecycle: FC<{
         });
     };
 
-    if (isLifecycleImprovementsEnabled) {
-        return currentStage ? (
-            <FeatureLifecycleTooltip
-                stage={currentStage!}
-                project={feature.project}
-                onArchive={onArchive}
-                onComplete={onComplete}
-                onUncomplete={onUncompleteHandler}
-                loading={loading}
-            >
-                <FeatureLifecycleStageIcon stage={currentStage} />
-            </FeatureLifecycleTooltip>
-        ) : null;
-    }
-
     return currentStage ? (
-        <LegacyFeatureLifecycleTooltip
+        <FeatureLifecycleTooltip
             stage={currentStage!}
             project={feature.project}
             onArchive={onArchive}
@@ -66,6 +48,6 @@ export const FeatureLifecycle: FC<{
             loading={loading}
         >
             <FeatureLifecycleStageIcon stage={currentStage} />
-        </LegacyFeatureLifecycleTooltip>
+        </FeatureLifecycleTooltip>
     ) : null;
 };