Skip to content

Commit 138410e

Browse files
authored
chore: drop release plan template view permissions (#9195)
https://linear.app/unleash/issue/2-3225/drop-the-release-template-view-permissions Drops the release plan template view permissions in favor of an "open by default" approach. Should merge the Enterprise PR first.
1 parent f9e0c27 commit 138410e

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

src/lib/types/permissions.ts

-5
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ export const PROJECT_DEFAULT_STRATEGY_WRITE = 'PROJECT_DEFAULT_STRATEGY_WRITE';
8080
export const PROJECT_CHANGE_REQUEST_WRITE = 'PROJECT_CHANGE_REQUEST_WRITE';
8181
export const PROJECT_SETTINGS_WRITE = 'PROJECT_SETTINGS_WRITE';
8282

83-
export const RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW =
84-
'RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW';
85-
export const RELEASE_PLAN_TEMPLATE_VIEW = 'RELEASE_PLAN_TEMPLATE_VIEW';
8683
export const RELEASE_PLAN_TEMPLATE_CREATE = 'RELEASE_PLAN_TEMPLATE_CREATE';
8784
export const RELEASE_PLAN_TEMPLATE_UPDATE = 'RELEASE_PLAN_TEMPLATE_UPDATE';
8885
export const RELEASE_PLAN_TEMPLATE_DELETE = 'RELEASE_PLAN_TEMPLATE_DELETE';
@@ -140,8 +137,6 @@ export const ROOT_PERMISSION_CATEGORIES = [
140137
{
141138
label: 'Release plan templates',
142139
permissions: [
143-
RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW,
144-
RELEASE_PLAN_TEMPLATE_VIEW,
145140
RELEASE_PLAN_TEMPLATE_CREATE,
146141
RELEASE_PLAN_TEMPLATE_DELETE,
147142
RELEASE_PLAN_TEMPLATE_UPDATE,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
exports.up = (db, cb) => {
2+
db.runSql(`
3+
DELETE
4+
FROM permissions
5+
WHERE permission IN
6+
('RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', 'RELEASE_PLAN_TEMPLATE_VIEW');
7+
`, cb);
8+
9+
};
10+
11+
exports.down = (db, cb) => {
12+
db.runSql(`
13+
INSERT INTO permissions(permission, display_name, type) VALUES
14+
('RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', 'View overview of release plan templates', 'root'),
15+
('RELEASE_PLAN_TEMPLATE_VIEW', 'View details of specific release plan template', 'root');
16+
INSERT INTO role_permission(role_id, permission, created_by_user_id)
17+
SELECT id, 'RELEASE_PLAN_TEMPLATE_VIEW_OVERVIEW', '-1337' FROM roles WHERE name IN ('Viewer', 'Editor') AND type = 'root';
18+
INSERT INTO role_permission(role_id, permission, created_by_user_id)
19+
SELECT id, 'RELEASE_PLAN_TEMPLATE_VIEW', '-1337' FROM roles WHERE name = 'Editor' AND type = 'root';
20+
`, cb);
21+
};

0 commit comments

Comments
 (0)