Skip to content

Commit 111a676

Browse files
chore: remove deprecated getAdmin from client features store (#9497)
This method has been deprecated 2 years ago and is not used
1 parent d0597bc commit 111a676

File tree

3 files changed

+2
-33
lines changed

3 files changed

+2
-33
lines changed

src/lib/features/client-feature-toggles/client-feature-toggle-store.ts

-19
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,6 @@ export interface IGetAllFeatures {
3131
userId?: number;
3232
}
3333

34-
export interface IGetAdminFeatures {
35-
featureQuery?: IFeatureToggleQuery;
36-
archived?: boolean;
37-
userId?: number;
38-
}
39-
4034
export default class FeatureToggleClientStore
4135
implements IFeatureToggleClientStore
4236
{
@@ -369,19 +363,6 @@ export default class FeatureToggleClientStore
369363
requestType: 'playground',
370364
});
371365
}
372-
373-
async getAdmin({
374-
featureQuery,
375-
userId,
376-
archived,
377-
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
378-
return this.getAll({
379-
featureQuery,
380-
archived: Boolean(archived),
381-
requestType: 'admin',
382-
userId,
383-
});
384-
}
385366
}
386367

387368
module.exports = FeatureToggleClientStore;

src/lib/features/client-feature-toggles/fakes/fake-client-feature-toggle-store.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import type {
44
IFeatureToggleQuery,
55
} from '../../../types/model';
66
import type { IFeatureToggleClientStore } from '../types/client-feature-toggle-store-type';
7-
import type { IGetAdminFeatures } from '../client-feature-toggle-store';
87

98
export default class FakeClientFeatureToggleStore
109
implements IFeatureToggleClientStore
@@ -16,7 +15,7 @@ export default class FakeClientFeatureToggleStore
1615
archived: boolean = false,
1716
): Promise<IFeatureToggleClient[]> {
1817
const rows = this.featureToggles.filter((toggle) => {
19-
if (featureQuery.namePrefix) {
18+
if (featureQuery?.namePrefix) {
2019
if (featureQuery.project) {
2120
return (
2221
toggle.name.startsWith(featureQuery.namePrefix) &&
@@ -27,7 +26,7 @@ export default class FakeClientFeatureToggleStore
2726
}
2827
return toggle.name.startsWith(featureQuery.namePrefix);
2928
}
30-
if (featureQuery.project) {
29+
if (featureQuery?.project) {
3130
return featureQuery.project.some((project) =>
3231
project.includes(toggle.project),
3332
);
@@ -73,13 +72,6 @@ export default class FakeClientFeatureToggleStore
7372
}));
7473
}
7574

76-
async getAdmin({
77-
featureQuery: query,
78-
archived,
79-
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
80-
return this.getFeatures(query, archived);
81-
}
82-
8375
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
8476
async createFeature(feature: any): Promise<void> {
8577
this.featureToggles.push({

src/lib/features/client-feature-toggles/types/client-feature-toggle-store-type.ts

-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import type {
22
IFeatureToggleClient,
33
IFeatureToggleQuery,
44
} from '../../../types/model';
5-
import type { IGetAdminFeatures } from '../client-feature-toggle-store';
65

76
export interface IFeatureToggleClientStore {
87
getClient(
@@ -16,7 +15,4 @@ export interface IFeatureToggleClientStore {
1615
getPlayground(
1716
featureQuery: Partial<IFeatureToggleQuery>,
1817
): Promise<IFeatureToggleClient[]>;
19-
20-
// @Deprecated
21-
getAdmin(params: IGetAdminFeatures): Promise<IFeatureToggleClient[]>;
2218
}

0 commit comments

Comments
 (0)