Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin DisplayProgressInLCD to use M118 besides M117 and M73 #10914

Closed
inigoml opened this issue Nov 23, 2021 · 10 comments
Closed

Allow plugin DisplayProgressInLCD to use M118 besides M117 and M73 #10914

inigoml opened this issue Nov 23, 2021 · 10 comments
Labels
Type: New Feature Adding some entirely new functionality.

Comments

@inigoml
Copy link
Contributor

inigoml commented Nov 23, 2021

Is your feature request related to a problem?

I've an Artillery printer with BigTree Tech TFT. This display does not show progress when printing via Octoprint due to not manage M117 messages. It would be nice to add M118 serial message support in order to allow send messages to TFT.

Describe the solution you'd like

Add not only M73 or M117 messages but also M118.

Describe alternatives you've considered

Print form TF or USB without using Octoprint.

Affected users and/or printers

Artillery Sidewinder X1/X2, Genius, Genius Pro.

Additional information & file uploads

DisplayProgressOnLCD.zip
Attached modified script for Cura 4.11.2. Easy to integrate in Cura main branch.

@inigoml inigoml added the Type: New Feature Adding some entirely new functionality. label Nov 23, 2021
@inigoml
Copy link
Contributor Author

inigoml commented Nov 23, 2021

This is how it's seen from Cura.
image

@rust84
Copy link

rust84 commented Nov 28, 2021

Nice feature. I would suggest P0 as a default rather than P2 and this will broadcast it on all serial ports for people who have a display connected to P1. Tested with an Ender 3 and SKR Mini E3 V2 + TFT35.

Would be useful with bigtreetech/BIGTREETECH-TouchScreenFirmware#2241

@digant73
Copy link

it should be better that the current plugin can be enhanced to support the commands in PR bigtreetech/BIGTREETECH-TouchScreenFirmware#2241 (now merged on the last BTT TFT fw). In particular, the plugin must support also actions:
action:print_start
action:print_end
allowing the TFT to switch/close the Printing menu

@fvrmr
Copy link
Contributor

fvrmr commented Nov 30, 2021

Hi @inigoml thank you for your request. Since you've already made a script you can create a pull request! Let me know if you have questions about creating a pull request!

@inigoml
Copy link
Contributor Author

inigoml commented Nov 30, 2021

Updated script for M118 support with @digant73 last TFT mod.
DisplayProgressOnLCD.zip

@inigoml
Copy link
Contributor Author

inigoml commented Nov 30, 2021

Hi @inigoml thank you for your request. Since you've already made a script you can create a pull request! Let me know if you have questions about creating a pull request!

Will do!

@inigoml
Copy link
Contributor Author

inigoml commented Nov 30, 2021

PR: #10972

@inigoml
Copy link
Contributor Author

inigoml commented Nov 30, 2021

PXL_20211130_181225850

@digant73
Copy link

@inigoml Just to make clear the feature you are implementing, please add in the description of the PR also a reference to the Octoprint support implemented on the BTT TFT (so bigtreetech/BIGTREETECH-TouchScreenFirmware#2241)

@inigoml
Copy link
Contributor Author

inigoml commented Nov 30, 2021

@digant73 Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Adding some entirely new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants