Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for sub-domain rules within domain rule type #107

Open
Jay-o-Way opened this issue Mar 19, 2024 · 2 comments
Open

Support for sub-domain rules within domain rule type #107

Jay-o-Way opened this issue Mar 19, 2024 · 2 comments
Labels
Feature Enhancement Update existing feature
Milestone
Maybe at v1.0.0

Comments

@Jay-o-Way
Copy link
Contributor

image
@U-C-S
Copy link
Owner

U-C-S commented Mar 19, 2024

should it work with docs.github.com domain rule , then it's working as intended. atleast for now.

Honestly I was confused about handling the case of sub-domains. Maybe In future, I can have extra option for also including sub-domains as a checkbox.

@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Mar 19, 2024 •
edited
Loading

I assumed that the rule would capture the top domain. Note that the example of *.domain.com literally implies a sub-domain 🤓

@U-C-S U-C-S changed the title Using domain doesn't work Support for sub-domain rules within domain rule type Mar 19, 2024
@U-C-S U-C-S added the Feature Enhancement Update existing feature label Mar 19, 2024
@U-C-S U-C-S added this to the Maybe at v1.0.0 milestone Mar 19, 2024
@U-C-S U-C-S mentioned this issue Feb 27, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Enhancement Update existing feature
Projects
None yet
Milestone
Maybe at v1.0.0
Development

No branches or pull requests
2 participants
@U-C-S @Jay-o-Way