Do not proxy _is_coroutine attr, fixes #136 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amol-
reviewed
May 19, 2023
tg/support/objectproxy.py
Outdated
| @@ -16,11 +16,12 @@ def __dir__(self): | |||
| return dir_list | |||
|
|
|||
| def __getattr__(self, attr): | |||
| if attr.startswith("__"): | |||
| if attr.startswith("__") or attr == '_is_coroutine': | |||
There was a problem hiding this comment.
Dunder methods were a general solution, but I'd like to avoid growing a chain of or on long term. Can't we just add _is_coroutine as an attribute of TurboGearsObjectProxy? It simply can be None to make iscoroutinefunction happy: https://github.com/python/cpython/blob/3bc94e678f2961eafc9d665898d73afc6204d314/Lib/asyncio/coroutines.py#L20-L23
There was a problem hiding this comment.
Yep I think that'd work well
brondsem
force-pushed
the
proxy_iscoroutinefunction
branch
from
ec1bcaf to
b171594
Compare
|
I force-pushed an updated commit with your suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #136 with similar approach to dunder methods