Undo/Redo stop working, only resume working after a reset #4152
Comments
|
I've had this happen a few times on 2021.1 so it definitely isn't caused by more recent changes. |
|
I also reported this on Discord, been using TB extensively and for long periods of time, this never happened to me on 2022.1 or any older version, and it's been happening to me quite often. I'm still not quite sure on how to reproduce this but, I thought it could be something related to using TB for long periods, however, this just happened to me not long after I had to restart the editor for the same reason, and I had just used the vertex clipping tool - using keyboard shortcut - and with CTRL + Enter to change the cut orientation. Could be related. Couldn't exactly reproduce but I'll keep trying. |
kduske
added
Prio:1
|
Yeah I'm getting this a lot as well, but no idea what triggers it for now. :( |
|
Does any of you remember what the undo and redo menu items read exactly? Was it just "Undo", or "Undo " - if the latter, what command was it? Also, if you run into this again, please report this info here - just write down what the undo and redo menu items said exactly. |
|
At the bottom of this page there are builds of current master where I have enabled logging of all commands and transactions. You will find that the log window will contain a lot of information. If you want to help debug this issue, please try to run this build and if you notice that Undo is disabled, just copy and paste the last 50 or so lines from the log panel here. Additionally, please write down what the menu items say exactly, e.g. "Undo " or just "Undo" for both undo and redo. Thanks! |
|
Gonna try this build. I'm almost sure it's something related to brush editing: either resizing, clipping, moving... because I was having this issue while I was heavily editing the map geometry. When I stopped doing brush work and started working with entities, this issue didn't occur. |
|
Took me a while but it happened Starting transaction '' And this is also the end of the log. After that just a save entry. |
|
Thanks! Do you remember what the title of the undo and redo menu items was? |
|
I checked, could see just "Undo" and "Redo", if it had a space like "Undo " I couldn't spot. |
|
Again, doing different things: Starting transaction 'Select Object'
|
|
@kduske pains me to say it, but this is still present in TrenchBroom 2023.1 Build v2023.1-RC1 Release Win64. :( I've been having it regularly when using lots of nested Linked Groups, still don't know how to reproduce it... |
|
I must be using a different RC version (RC1-3?). Been using it extensively and the issue has not occurred once. Already reported to @kduske about it. [EDIT] I hate myself. As soon as I posted this, the issue occurred for the first time. I'm not kidding. Alt tabbed back to TB, hit Ctrl Z, and gone... |
Does that mean that Undo was disabled after you hit CTRL+Z or that you fixed a disabled undo by alt-tabbing and hitting CTRL+Z? |
|
One interesting thing to note maybe, is that when it happened for me just now, the linked group also stopped updating as usual (we had this issue a while back) like if I delete a brush from inside one group, the others won't update until I move a brush, which is not the usual behaviour. |
|
It could be an unhandled exception during a transaction that leads to the transaction not being closed properly. Here's a build that will throw an error if this occurs: https://github.com/TrenchBroom/TrenchBroom/actions/runs/4178495422 Once the builds are finished, could you please try that? Please save often as it will crash if I'm right. |
Right after I wrote that reply, I alt+tabbed back to TB and the Undo stopped working. But yesterday it didn't occur. It's been very rare. I don't use Linked Groups but I'm always using groups and editing inside them. |
|
@wedge-one @bstordeur has either of you tried out the build I linked above? |
|
I've switched to it but haven't had much mapping time last few days. Hopefully I can get some time in today. |
|
I had totally forgotten, when I clicked the link it was still building. I'm still using that old build, doing a lot of mapping and didn't get the issue once after that only one time. And sometimes I have more than one instance of TB running and no issues. If I hadn't had that issue that day, I would say it was fixed in my end. Gonna try this build right now and tell you the results. |
|
Issue just occurred, not long after opening my map. Yesterday worked just fine with a long mapping session. Didn't catch exactly when it happened, but some of my recent actions were (in order):
|
|
Were you using the build I linked above? |
Yes, TrenchBroom-Win64-v2023.1-RC1-19-gc1e246c51-Release |
|
Ah, that's interesting, so it wasn't an unhandled exception in your case. |
|
Just a follow-up: used the same instance of TB yesterday for the whole day, did all kinds of operations, and no Undo issue. |
|
I just had a report from ComfyByTheFire on the Quake Mapping Discord it is still happening for them on 2023.1. |
|
I think I finally found the cause of this and have fixed it. I'm closing this, but if it happens again after the next release, let me know. |
on TrenchBroom 2022.2, multiple users have reported that Undo/Redo stop working through keyboard shortcut AND menu option.
They only resume working after closing and restarting TB.
No steps to reproduce are known.
The text was updated successfully, but these errors were encountered: