[DCK] No volume versions #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
requested review from
cubells,
chienandalu,
luismontalba,
pedrobaeza,
sergio-teruel and
carlosdauden
|
Check out #67 (comment) to avoid retrocompatibility problems. |
|
Have you tried this? I tried in one project and there was an error because in some point it requires db numbered volume. In Docker, isn't there the possibility of renaming existing volumes? |
|
It should be fixed now.
Not AFAIK |
pedrobaeza
approved these changes
Sep 21, 2017
|
This breaking change has been merged, so this should be commented for letting everyone knows about that (merge operations are not sent). |
|
Yes, it was advertised at #67 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
The purpose of this feature was that you were able to quickly switch branches in the project by using git, and avoid different branches to share the same volumes, since that can lead to errors in different Odoo versions.
At the end of the day, it turns out that feature was not used. Most version switching happens in devel, where you'd have to re-run
setup-develstuff, which slowed down the devel process too much.Other version switches happened when running OpenUpgrade among versions, and in these cases we need to share the same volume among versions, so this "feature" was becoming a "bug".
So, finally we decided to drop it. This eases the initial scaffolding setup (less things to change). If we need different versions, it's as easy as having different clones, one on each branch, or switching the env
COMPOSE_PROJECTvariable.