Change default fonts to liberation #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current fonts shipped by Debian do not render fine in Adobe PDF on Windows and Mac OS. Most users will use those OS & PDF reader combination, and [Odoo demos and runbots use MS fonts][1]. So, in the hope of providing an opinionated sane default that makes most users happy, we are going to ship Liberation fonts by default, which are an open source alternative to MS fonts that, according to tests, render just fine everywhere. If anybody wants a more corporative font, they should use it in their reports and install it from apt with provided tools. [1]: odoo/odoo#27487 (comment)
yajo
added a commit
that referenced
this pull request
Sep 16, 2019
In #181 and #188 we added Liberation fonts as the default ones for reports. However this made it a little bit harder to choose a different default font (default fonts are the ones that the system interprets for `monospace`, `sans-serif` and `serif`). From now on, if you want to override the default fonts, you have to add the package in `dependencies/apt.txt` or a `build.d` script, and add one or more of these new build arguments: `FONT_{MONO,SANS,SERIF}`. This way you make sure to override the default fonts. Before this, if you only added the package, it only made those fonts available, *not default*.
yajo
added a commit
that referenced
this pull request
Sep 16, 2019
In #181 and #188 we added Liberation fonts as the default ones for reports. However this made it a little bit harder to choose a different default font (default fonts are the ones that the system interprets for `monospace`, `sans-serif` and `serif`). From now on, if you want to override the default fonts, you have to add the package in `dependencies/apt.txt` or a `build.d` script, and add one or more of these new build arguments: `FONT_{MONO,SANS,SERIF}`. This way you make sure to override the default fonts. Before this, if you only added the package, it only made those fonts available, *not default*.
yajo
added a commit
that referenced
this pull request
Sep 17, 2019
In #181 and #188 we added Liberation fonts as the default ones for reports. However this made it a little bit harder to choose a different default font (default fonts are the ones that the system interprets for `monospace`, `sans-serif` and `serif`). From now on, if you want to override the default fonts, you have to add the package in `dependencies/apt.txt` or a `build.d` script, and add one or more of these new build arguments: `FONT_{MONO,SANS,SERIF}`. This way you make sure to override the default fonts. Before this, if you only added the package, it only made those fonts available, *not default*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current fonts shipped by Debian do not render fine in Adobe PDF on Windows and Mac OS.
Most users will use those OS & PDF reader combination, and Odoo demos and runbots use MS fonts.
So, in the hope of providing an opinionated sane default that makes most users happy, we are going to ship Liberation fonts by default, which are an open source alternative to MS fonts that, according to tests, render just fine everywhere.
If anybody wants a more corporative font, they should use it in their reports and install it from apt with provided tools.