Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python in v11 image (switch base) #178

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Update python in v11 image (switch base) #178

merged 1 commit into from
Nov 5, 2018

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Nov 5, 2018

The outdated and buggy Python 3.5 version that Debian 9 ships was triggering werid behaviors in some production instances.

I switch here the base to Docker Hub's python:3.5-stretch, which shares the same underlying OS, but uses latest Python 3.5 (3.5.6 as of today) and gets updates faster.

The main upgrade problem would be that projects adding python-dev to their apt_build.txt files should remove it now. Not a big problem nor fix, so it seems legit for the stable release.

The outdated and buggy Python 3.5 version that Debian 9 ships was triggering werid behaviors in some production instances.

I switch here the base to Docker Hub's `python:3.5-stretch`, which shares the same underlying OS, but uses latest Python 3.5 (3.5.6 as of today) and gets updates faster.

The main upgrade problem would be that projects adding `python-dev` to their `apt_build.txt` files should remove it now. Not a big problem nor fix, so it seems legit for the stable release.
@yajo yajo added the bug label Nov 5, 2018
@yajo yajo self-assigned this Nov 5, 2018
@yajo yajo requested a review from sergio-teruel November 5, 2018 11:01
@pedrobaeza
Copy link
Member

And if you need that library for installing some pip libraries?

@yajo
Copy link
Contributor Author

yajo commented Nov 5, 2018

It's shipped now in the base image, so no need to install it. In fact, if you install it, you'd end up having 2 different versions of python development headers, so to avoid confusion, just remove that line from dependencies and you're done.

@pedrobaeza
Copy link
Member

OK, good to know. Maybe you should put an announcement in the breaking changes thread.

@yajo
Copy link
Contributor Author

yajo commented Nov 5, 2018

I'm writing it right now 😉

@yajo yajo merged commit 390897f into master Nov 5, 2018
@yajo yajo deleted the v11-python-base branch November 5, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants