-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolidJS driver for TanStack Start #3522
Draft
birkskyum
wants to merge
58
commits into
TanStack:main
Choose a base branch
from
birkskyum:tanstack-solid-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 1bc9aaa.
☁️ Nx Cloud last updated this comment at |
6686a0b
to
4382f2f
Compare
fd0e9e0
to
809e7ff
Compare
dc8f144
to
384689f
Compare
e98b210
to
9d0c941
Compare
86452cb
to
efaab75
Compare
f335f15
to
7c76170
Compare
212c51c
to
35745c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce support for Solid to be used with TanStack Start.
The PR is in draft, because there're several ongoing refactors that can influence the timing of when it's most feasible to introduce the solid driver.
Status (build and run e2e/solid-start/basic)
Ongoing refactors
Refactor to make router packages (aka. client-only features) more agnostic:
Refactor to make start packages (aka. server features) more agnostic:
Refactor of start packages from vinxi to a Nitro vite plugin and Vite Env API: