Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): Library v2 Agents and Presets #9258

Merged
merged 21 commits into from
Feb 13, 2025
Merged

feat(backend): Library v2 Agents and Presets #9258

merged 21 commits into from
Feb 13, 2025

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jan 13, 2025 •
edited
Loading

This re-introduces changes from the following PRs with fixes:

Changes 🏗️

Fixes:

  • Fix Prisma query statements in v2.library.db
  • Fix creation of (library) agents
  • Fix test cleanup of (library) agents
  • Fix handling and passing of node_input parameters

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Create & run a new agent
    • Update & run an existing agent

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 7b7a247
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67ae1d21ab0c46000876a36d

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/xl labels Jan 13, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 7b7a247
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67ae1d21901c600008a98c41

@Pwuts
Merge branch 'pwuts/open-2309-fix-db-error-could-not-find-field-at' i…
700f2a3 
…nto pwuts/open-2314-fix-up-and-re-introduce-library-v2-back-end-work
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Pwuts Pwuts mentioned this pull request Jan 14, 2025
Merged
3 tasks
@Pwuts Pwuts force-pushed the pwuts/open-2314-fix-up-and-re-introduce-library-v2-back-end-work branch from a8ac410 to 85180e1 Compare January 15, 2025 11:03
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@Swiftyos
Copy link
Contributor

@Pwuts are you okay with me picking this up again now I'm back?

@Swiftyos
Copy link
Contributor

Swiftyos commented Jan 31, 2025 •
edited
Loading

See #9357, I've cherry picked your changes into my branch

@Swiftyos Swiftyos closed this Jan 31, 2025
@Pwuts Pwuts reopened this Feb 12, 2025
@Pwuts Pwuts force-pushed the pwuts/open-2314-fix-up-and-re-introduce-library-v2-back-end-work branch from 80acf46 to a1b8e60 Compare February 12, 2025 00:10
@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Feb 12, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Feb 12, 2025 •
edited
Loading

Here's the code health analysis summary for commits b5b9a00..7b7a247. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ Success
❗ 42 occurences introduced
🎯 20 occurences resolved
View Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Swiftyos

This comment was marked as outdated.

Sign in to view
@Swiftyos Swiftyos closed this Feb 12, 2025
@Swiftyos Swiftyos reopened this Feb 12, 2025
@Pwuts Pwuts marked this pull request as ready for review February 12, 2025 13:35
@Pwuts Pwuts requested a review from a team as a code owner February 12, 2025 13:35
@Pwuts Pwuts requested review from kcze and majdyz and removed request for a team February 12, 2025 13:35
@Pwuts Pwuts force-pushed the pwuts/open-2314-fix-up-and-re-introduce-library-v2-back-end-work branch from 92ee106 to 158e32d Compare February 12, 2025 15:27
@Pwuts Pwuts requested a review from ntindle February 12, 2025 21:09
@majdyz majdyz removed their request for review February 13, 2025 10:27
@Pwuts Pwuts force-pushed the pwuts/open-2314-fix-up-and-re-introduce-library-v2-back-end-work branch from 91a606e to 680ad03 Compare February 13, 2025 15:45
@Pwuts Pwuts added this pull request to the merge queue Feb 13, 2025
Merged via the queue into dev with commit ce1d63c Feb 13, 2025
27 checks passed
@Pwuts Pwuts deleted the pwuts/open-2314-fix-up-and-re-introduce-library-v2-back-end-work branch February 13, 2025 17:49
@Pwuts Pwuts mentioned this pull request Feb 18, 2025
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2025
@Pwuts
fix(frontend): Fix return type and usage of api.listLibraryAgents() (…
d1832ce 
…#9498)

- Follow-up to #9258

The front end is fetching `/library/agents` -> `LibraryAgent[]` but
using the result as `GraphMeta[]`. This breaks a bunch of things.

### Changes 🏗️

Frontend:
- Add `LibraryAgent` type for `api.listLibraryAgents()`
- Amend all broken usages of `LibraryAgent` objects
- Introduce branded typing for `LibraryAgent.id` and `GraphMeta.id` to
disallow mixing them. This prevents incorrect use in the future, and
reduces the chance of this frontend issue accumulating interest on
existing open PRs.

Backend:
- Add a migration to create `LibraryAgent` objects for all existing
`AgentGraphs`


### Checklist 📋

#### For code changes:
- [x] I have clearly listed my changes in the PR description
- [x] I have made a test plan
- [x] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->
- [x] Check that all existing agents are listed in the agents list on
`/monitoring` (check against DB or `GET /api/graphs`)
  - [x] Check that all views of `/monitoring` work
  - [x] Try to run an agent and check its status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle approved these changes

@kcze kcze Awaiting requested review from kcze kcze is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/xl
Projects
Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pwuts @Swiftyos @ntindle