Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally build sipp_unittest #626

Open
chenrui333 opened this issue Apr 3, 2023 · 1 comment
Open

Conditionally build sipp_unittest #626

chenrui333 opened this issue Apr 3, 2023 · 1 comment

Comments

@chenrui333
Copy link

It would be great to introduce BUILD_TESTING flag to conditionally build sipp_unittest so that the gtest dependency would be also conditionally pulled into the build.
@rkday rkday mentioned this issue May 19, 2023
Merged
@rkday
Copy link
Contributor

rkday commented May 19, 2023

In v3.7.1 we cope better with gtest being unavailable - does that meet your use-case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chenrui333 @rkday