Fix: Handle TypeError in #onError and removeAllListeners in digging.js #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are these checks needed ? |
extremeheat
requested changes
Feb 7, 2025
| if (bot.listenerCount('diggingCompleted') > 0) { | ||
| bot.removeAllListeners('diggingCompleted'); | ||
| } | ||
| if (typeof bot.stopDigging === 'function') { |
There was a problem hiding this comment.
In what situation is this not defined?
There was a problem hiding this comment.
It happens when the bot dies. This is the full error:
200 | #onClose(e) {
201 | this.#onExitPromise = e.code, this.emit("exit", e.code);
202 | }
203 | #onError(event) {
204 | let error = event?.error;
205 | error = new Error(event.message, { cause: event });
^
error: 208 |
209 | await diggingTask.promise
210 | }
211 |
212 | bot.on('death', () => {
213 | bot.removeAllListeners('diggingAborted');
^
TypeError: undefined is not an object (evaluating 'this._events')
at removeAllListeners (node:events:244:25)
at <anonymous> (/home/dimonchi/Project-Archive-Minecraft/node_modules/mineflayer/lib/plugins/digging.js:213:9)
at emit (node:events:84:22)
at <anonymous> (/home/dimonchi/Project-Archive-Minecraft/node_modules/mineflayer/lib/plugins/health.js:25:13)
at emit (node:events:90:22)
at emitPacket (/home/dimonchi/Project-Archive-Minecraft/node_modules/minecraft-protocol/src/client.js:84:12)
at <anonymous> (/home/dimonchi/Project-Archive-Minecraft/node_modules/minecraft-protocol/src/client.js:113:9)
at emit (node:events:87:22)
at addChunk (/home/dimonchi/Project-Archive-Minecraft/node_modules/readable-stream/lib/internal/streams/readable.js:323:12)
at readableAddChunk (/home/dimonchi/Project-Archive-Minecraft/node_modules/readable-stream/lib/internal/streams/readable.js:300:9)
at #onError (node:worker_threads:205:15)
Aborted (core dumped)
There was a problem hiding this comment.
This seems like a problem with your code, not mineflayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks before removing listeners to prevent crash.