Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming refactor #52

Merged
merged 18 commits into from
Feb 23, 2025
Merged

Naming refactor #52

merged 18 commits into from
Feb 23, 2025

Conversation

alexchristy
Copy link
Member

@alexchristy alexchristy commented Feb 22, 2025

Checklist

  • I have added a version label to my PR (e.g., patch, minor, major).
  • I have tested my changes locally and verified they work as expected.
  • I have added relevant tests to cover my changes.
  • I have made any necessary updates to the documentation.

Description

Went through and renamed all objects, fles, and functions that deal with ranges, vpcs, subnets, and hosts with a template prefix. This will prevent confusion in the future when introducing deployed range objects.

Ex: OpenLabsRangeSchema --> TemplateRangeSchema

Sorry, something went wrong.

@alexchristy alexchristy added the patch Increment the patch version when merged label Feb 22, 2025
Copy link
Member

@Nareshp1 Nareshp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Adamkadaban Adamkadaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im a fan

@alexchristy alexchristy merged commit 5e7b9a2 into main Feb 23, 2025
4 checks passed
@alexchristy alexchristy deleted the naming-refactor branch February 23, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants