-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug docker config to work with vscode debugging extension #32
Conversation
Clarify .env file in case docker isn't used Add debugging section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably missed it, but for code changes and auto reload to work in the debug container don't we need a volume for the fastapi container?
@alexchristy Isn't that in the |
Oh yea there it is. For some reason I looked over it several times and missed it 🫠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Description
.vscode/launch.json
for debugging to be committeddocker compose
instead ofdocker-compose
in READMEFixes: #28