Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection of chapters. Actually one chapter have division that really don't exist #24

Open
fabianhtml opened this issue Mar 10, 2014 · 9 comments

Comments

@fabianhtml
Copy link

No description provided.

@IniTW8X
Copy link

IniTW8X commented Mar 10, 2014

Also, on few epubs I found out that first chapter starts with some metadata (which are NOT text in epub) such as padding:...margin:0pt}...body...text-align:center; etc.

@OnlyInAmerica
Copy link
Owner

It seems the first "Chapter" is almost always meta data / CSS, and also "Chapters" that punctuate two actual chapters. I'll look into this.

@IniTW8X
Copy link

IniTW8X commented Mar 12, 2014

Also, sometimes after finishing a chapter, the text stream jumps at the beginning of the chapter instead of continuing with next chapter.

@eekd
Copy link

eekd commented Mar 13, 2014

I have a similar issue with some epubs that choosing a chapter starts the book from the beginning.

@haz3m
Copy link

haz3m commented Mar 14, 2014

I also have problems with the chapters. Once a chapter is finished, it returns to the beginning of this chapter, however, the indicator (bottom left) goes well in the next chapter. I have went through this counter to restart the chapter and then the application reads the correct one.
To be clear: I read Chapter 2, at the end, the meter displays Chapter 3 but reread Chapter 2. Via the counter, I throw again the Chapter 3 and the apk reads well Chapter 3.

@IniTW8X
Copy link

IniTW8X commented Mar 19, 2014

As for the latest build, book reading stops after the first chapter. And there's no way to switch to next chapters because in chapter list is listed only the first chapter. I hope it's only a semi-step to working chapter-recognition :)

@OnlyInAmerica
Copy link
Owner

Could you send me the epubs that are causing these problems?

There are some changes in 6b44f03 that significantly improves handling of epubs with Table of Contents.

@IniTW8X
Copy link

IniTW8X commented Mar 19, 2014

I builded apk with the last commit and just sent you to email 2 epubs that did not and are not working now. Meaning I can't get through first chapter.

@IniTW8X
Copy link

IniTW8X commented Mar 20, 2014

After last commits the epubs are readable again ;)
So what remains now is to solve the chapter jumping issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants