Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Segmentation not loaded by default with initialSeriesInstanceUID #4593

Closed
xbankov opened this issue Dec 11, 2024 · 3 comments · Fixed by #4605
Closed

[Bug] Segmentation not loaded by default with initialSeriesInstanceUID #4593

xbankov opened this issue Dec 11, 2024 · 3 comments · Fixed by #4605
Labels
Bugs Bug reported, reproducible, and verified.

Comments

@xbankov
Copy link

xbankov commented Dec 11, 2024

Describe the Bug

Parameter initialSeriesInstanceUID is not loading the segmentation by default.

Steps to Reproduce

  1. Go to https://viewer.ohif.org/viewer?StudyInstanceUIDs=61.7.93273854116647800470730671671118421206&initialSeriesInstanceUID=61.7.280176113695462316231376981119115690926

The current behavior

Segmentation present but not loaded by default.

The expected behavior

Segmentation loads by default.

OS

Not applicable

Node version

Not applicable

Browser

Mozilla Firefox 133.0, Google Chrome 131.0.6778.139

@xbankov xbankov added the Awaiting Reproduction Can we reproduce the reported bug? label Dec 11, 2024
@xbankov xbankov changed the title [Bug] Segmentation [Bug] Segmentation not loaded by default with initialSeriesInstanceUID Dec 12, 2024
Copy link
Member

sedghi commented Dec 12, 2024

Hmmmm

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Dec 12, 2024
@sedghi sedghi added the Bugs Bug reported, reproducible, and verified. label Dec 12, 2024 — with Linear
@xbankov
Copy link
Author

xbankov commented Dec 16, 2024

I have similar problems with the RTSTRUCT modality. I tried to look into it, and I realize in 3.7.0 it works as indented, and 3.8.0 is already not loading segmentations by default. We rollbacked to 3.7.0 because of that, unfortunately.

I was also surprised to see some segmentations not going through Segmentation Viewport when opened, as I setup logging in and some segmentation printed logs, and some not.

I cannot really see the difference between working and not working segmentations files itself, only that they not working ones have RTSTRUCT associated with them.

Any ideas? Maybe where to look, what was changed. I am glad to help.

@xbankov
Copy link
Author

xbankov commented Dec 18, 2024

Thanks for the fix!

@sedghi sedghi mentioned this issue Jan 16, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bug reported, reproducible, and verified.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants