-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] l10n_es_aeat_mod303_oss: Migration to 17.0 #4009
Open
Tisho99
wants to merge
26
commits into
OCA:17.0
Choose a base branch
from
sygel-technology:17.0-mig-l10n_es_aeat_mod303_oss
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] l10n_es_aeat_mod303_oss: Migration to 17.0 #4009
Tisho99
wants to merge
26
commits into
OCA:17.0
from
sygel-technology:17.0-mig-l10n_es_aeat_mod303_oss
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d6eb83
to
bf5c8bd
Compare
bf5c8bd
to
54c1e9a
Compare
@Tisho99 Could you rebase, please? |
- Standard procedure. - Add tests for full coverage. - Fix compatibility with `l10n_es_aeat_vat_prorrate` due to a problem with ormcache and virtual records.
- Standard procedure
Currently translated at 100.0% (1 of 1 strings) Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_aeat_mod303_oss Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_aeat_mod303_oss/ca/
Currently translated at 100.0% (1 of 1 strings) Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod303_oss Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod303_oss/es/
For proper OSS taxes creation after the fix in OCA/account-fiscal-rule#399.
54c1e9a
to
5b50fcb
Compare
Jesarregui
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration
Deleted old 2021 files and replaced for 2023 in tests
Refactored l10n.es.aeat.map.tax.line files and get_taxes function
T-7534