Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or change outdated comment (Lenovo ThinkPad X1 Yoga 7th-gen) #1370

Open
bittner opened this issue Feb 9, 2025 · 1 comment
Open

Comments

@bittner
Copy link

bittner commented Feb 9, 2025

In lenovo/thinkpad/x1/yoga/7th-gen a comment explains things that were okay 2+ years ago when this project was still on kernel 5.x (now we run 6.6.72).

  # This laptop is too new for the kernel currently in nixos-unstable.
  # On Kernel 5.15.x, dmesg shows the `hardware is newer than drivers` message.
  # When starting the system with 5.15.x, only a tty is being displayed.
  # After our tests, at least version 5.19 is required for the system to work properly.

Should this comment be removed or otherwise updated?

Heads-up to @MayNiklas who added the configuration on Oct 22, 2022.

@MayNiklas
Copy link
Member

I agree: since Kernel < 5.19 isn't a realistic setup anymore, this isn't really needed anymore.

I'm unsure about removing the "new enough kernel check":

  • on a newer kernel, it does nothing
  • it services as a source of information, that at least 5.19 is needed

At least the comment, that it's "too new", should be removed for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants