Refactor trigger decorator and deploy time evaluation logic #2290
+129
−121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
@trigger
logic and simplified the deploy time evaluation logic of@trigger
decorator. The current implementation is buggy and fails when runningtrigger4.py
in this gist here.For testing, refer to all the flows in this gist here. We can add few more tests as well if needed.
Change in contract:
Previously, we allowed deploy time functions (not documented anywhere) at various levels in the
@trigger
decorator. So something like this was possible:Now, we only allow specifying all of
parameters
as a deploy time function:These are also still allowed: