Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce connection pooling in metadata service #2258

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

savingoyal
Copy link
Collaborator

quick change to shave a second off of time taken to launch first task.

@nflx-mf-bot
Copy link
Collaborator

Testing[4163319] @ 6b2e8c4

_session.mount(
"http://",
requests.adapters.HTTPAdapter(
pool_connections=20,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you determine this number?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anecdotal -adjusting it higher or lower has no further practical impact.

@savingoyal savingoyal merged commit f8e4870 into master Feb 11, 2025
30 checks passed
@savingoyal savingoyal deleted the connection-pooling branch February 11, 2025 16:38
@nflx-mf-bot
Copy link
Collaborator

Testing[973] @ 6b2e8c4 had 1 FAILURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants