Support flow inheritance specifically around flow decorators. #2221
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow decorators are now properly merged when inheriting from other base flow specs.
|
Testing[4051277] @ e531c9d |
|
Testing[956] @ e531c9d had 6 FAILUREs. |
savingoyal
reviewed
Jan 22, 2025
| # in terms of the order; we will follow the MRO with the following rules: | ||
| # - decorators (cls._flow_decorators) will cause an error if they do not | ||
| # support multiple and we see multiple instances of the same | ||
| # - config decorators will be joined |
There was a problem hiding this comment.
together. I'll clarify.
savingoyal
approved these changes
Jan 22, 2025
|
Failures seem transient. Let me re-run. |
|
Testing[4051277] @ e531c9d |
|
Testing[956] @ e531c9d had 3 FAILUREs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow decorators are now properly merged when inheriting from other base flow specs.