Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Cases, but they can be Slack channels #4551

Merged
merged 16 commits into from
Apr 11, 2024

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Mar 26, 2024

Summary

A highly requested feature is for Cases to support dedicated channels, just like Incidents do today. This PR adds that functionality. We refactor some functions to use the Subject pattern, so that they work for both incidents, and cases. Notably, (Bookmarks and Announcement Messages).

When a dedicated channel Case is escalated to an Incident, we reuse the Conversation object for the new Incident. There was already a conditional in create_incident_resources that only created a conversation if one did not exist on the incident object, so we leverage this, and it worked seamlessly. Case channels are prepended with case- so that they are not ambiguous. The channel is renamed on escalation to the new Incident name and the case- is naturally removed at this point.

We add some Slack /slash commands to make the Case dedicate channel experience better. Allowing you to update cases and escalate them directly in Slack.

Miscellaneous Changes
  • We remove the participant announcement messages on Incident creation and replace them with a "bulk" version, that sends one message, with the number of participants added, and their cards.
  • We refactor the triage_flow for cases to use a match statement to improvement readability.
  • We add tooltips to the Case page for all resource icons, the private icon, and the escalate icon.
  • We truncate the description on the Case Type dropdown on the Case report form.

Screenshot 2024-03-26 at 3 03 44 PM

@wssheldon wssheldon added the enhancement New feature or request label Mar 26, 2024
@wssheldon
Copy link
Contributor Author

@mattsta Why the confused emoji?

@mattsta
Copy link
Contributor

mattsta commented Mar 27, 2024

oh, sorry, I didn't realize homepage reactions are actually issue reactions. didn't expect anybody to see it outside of the promo box itself (I always thought the home feed reactions were in their own isolated universe somehow?).

Screenshot 2024-03-26 at 18 24 58

initial reaction was more "cases are sad to have, wish everything just worked." i'd also disagree with it being "confused" emoji as they have it labeled? never noticed that was its official title before. always thought it was more "sad / sorry / condolences" but who knows.

I think per-case channels are a great idea though. Much better than the CEO dropping into #engineering with WHY IS THE WEBSITE DOWN then starting a secret video chat without any historical trace of troubleshooting progress and participants when new contacts/departments/helpers need to be brought in mid-event. 👍

@wssheldon wssheldon self-assigned this Mar 29, 2024
@wssheldon
Copy link
Contributor Author

@mvilanova @whitdog47 @metroid-samus Ready for review now if you'd like to take a look.

@wssheldon wssheldon changed the title [POC] - Cases, but they can be Slack channels [Enhancement] - Cases, but they can be Slack channels Apr 10, 2024
@wssheldon wssheldon merged commit 6bb06d4 into master Apr 11, 2024
8 checks passed
@wssheldon wssheldon deleted the poc/channel-cases branch April 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants