-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] - Cases, but they can be Slack channels #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mattsta Why the confused emoji? |
wssheldon
commented
Mar 27, 2024
wssheldon
commented
Mar 27, 2024
wssheldon
commented
Mar 27, 2024
mvilanova
reviewed
Mar 27, 2024
@mvilanova @whitdog47 @metroid-samus Ready for review now if you'd like to take a look. |
wssheldon
commented
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A highly requested feature is for Cases to support dedicated channels, just like Incidents do today. This PR adds that functionality. We refactor some functions to use the
Subject
pattern, so that they work for both incidents, and cases. Notably, (Bookmarks and Announcement Messages).When a dedicated channel Case is escalated to an Incident, we reuse the
Conversation
object for the newIncident
. There was already a conditional increate_incident_resources
that only created a conversation if one did not exist on the incident object, so we leverage this, and it worked seamlessly. Case channels are prepended withcase-
so that they are not ambiguous. The channel is renamed on escalation to the newIncident
name and thecase-
is naturally removed at this point.We add some Slack
/slash
commands to make theCase
dedicate channel experience better. Allowing you to update cases and escalate them directly in Slack.Miscellaneous Changes
Incident
creation and replace them with a "bulk" version, that sends one message, with the number of participants added, and their cards.triage_flow
for cases to use amatch
statement to improvement readability.Case
page for all resource icons, theprivate
icon, and theescalate
icon.Case Type
dropdown on the Case report form.