Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes breaking changes impacting incident ban threads feature #3321

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Fixes breaking changes impacting incident ban threads feature #3321

merged 3 commits into from
Apr 28, 2023

Conversation

mvilanova
Copy link
Contributor

This PR fixes breaking changes (here and here) introduced in this PR.

Screenshot 2023-04-28 at 11 15 26 AM

@mvilanova mvilanova requested review from kevgliss and wssheldon April 28, 2023 18:18
@mvilanova mvilanova added the bug Something isn't working label Apr 28, 2023
@wssheldon
Copy link
Contributor

Screenshot 2023-04-28 at 11 26 24 AM

I tested with threads banned and did not get the message within a Case thread.

wssheldon
wssheldon approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@wssheldon wssheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on the Case side. I tested:

  • Case creation
  • Main case message updates (edit, resolve, etc)
  • Signal deduplication thread message updates
  • Engagement thread messages

@mvilanova mvilanova merged commit 20132fa into master Apr 28, 2023
@mvilanova mvilanova deleted the bugfix/ban-threads branch April 28, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssheldon wssheldon wssheldon approved these changes

@kevgliss kevgliss Awaiting requested review from kevgliss

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvilanova @wssheldon