Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary error is logged when using NFS instead of iscsi #972

Open
c-goes opened this issue Feb 3, 2025 · 1 comment
Open

Unnecessary error is logged when using NFS instead of iscsi #972

c-goes opened this issue Feb 3, 2025 · 1 comment

Comments

@c-goes
Copy link

c-goes commented Feb 3, 2025

Describe the bug

In this line of code

Logc(ctx).Errorf("Portal '%v' is missing target IQN; it may not be considered for iSCSI self-healing.",

an error is logged even though publishInfo.IscsiTargetPortal is an empty string. In our case it is an empty string when using NFS.
The error message was a bit confusing when we tried to debug another problem.

The error was:

time="2024-12-16T09:18:33Z" level=error msg="Portal '' is missing target IQN; it may not be considered for iSCSI self-healing." logLayer=csi_frontend requestID=<requestID> requestSource="Internal workflow="plugin=activate"

Environment
Provide accurate information about the environment to help us reproduce the issue.

  • Trident version: [e.g. 19.10] 24.10
  • Trident installation flags used: [e.g. -d -n trident --use-custom-yaml]
  • Container runtime: [e.g. Docker 19.03.1-CE] containerd
  • Kubernetes version: [e.g. 1.15.1] 1.30.7
  • Kubernetes orchestrator: [e.g. OpenShift v3.11, Rancher v2.3.3] Rancher
  • Kubernetes enabled feature gates: [e.g. CSINodeInfo]
  • OS: [e.g. RHEL 7.6, Ubuntu 16.04] SLES 15 SP6
  • NetApp backend types: [e.g. CVS for AWS, ONTAP AFF 9.5, HCI 1.7]
  • Other:

To Reproduce

Use NFS and watch the log of trident pods.

Expected behavior

No error when using NFS regarding iSCSI self-healing.

@c-goes c-goes added the bug label Feb 3, 2025
@sjpeeris
Copy link
Collaborator

sjpeeris commented Feb 5, 2025

Hi @c-goes, we will investigate and fix this in a future release. Thanks !

@sjpeeris sjpeeris added tracked and removed tracked labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants