Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Resume parked print with m24 without lcd interaction. #27681

Open
prasadmanjulago opened this issue Feb 9, 2025 · 1 comment
Open

[FR] Resume parked print with m24 without lcd interaction. #27681

prasadmanjulago opened this issue Feb 9, 2025 · 1 comment
Labels
T: Feature Request Features requested by users.

Comments

@prasadmanjulago
Copy link

Is your feature request related to a problem? Please describe.

Hi sorry english is not my main language.

im pausing the print with m125.
And i need parking feature.. so advance parking feature enabled.
After the park, i cannot resume the print without LCD.
M24 doesnt work..

What im trying to do is enabling custom power loss recovery. I have a battery backup.but it cannot hold heat bed and nozzle..

So when a power loss detected , the printer pause the print. Park the head. Turn off heat bed and nozzle.. but doesnt power off steppers. When power comes on it needs to resume the print.. beacuse m125 needs LCD interaction, the print doesnt start.

Parking is must because if not oozed filement destroy the print.and when start the print, some layers will missing beacuse oozed filement..so parking is must .

Is there anywork around to this problem? I need to turn of lcd interaction on resume..

Thanks all..

Are you looking for hardware support?

No response

Describe the feature you want

Resume parked print with m24 without lcd interaction

Additional context

No response

@prasadmanjulago prasadmanjulago added the T: Feature Request Features requested by users. label Feb 9, 2025
@ellensp ellensp changed the title Resume parked print with m24 without lcd interaction. [FR] Resume parked print with m24 without lcd interaction. Feb 12, 2025
@classicrocker883
Copy link
Contributor

classicrocker883 commented Feb 20, 2025

Marlin\src\gcode\feature\pause\M125.cpp

/*
 *  With an LCD menu:
 *    P<bool>   = Always show a prompt and await a response
 */
void GcodeSuite::M125() {

... // rest of code

  // If possible, show an LCD prompt with the 'P' flag
  const bool show_lcd = TERN0(HAS_MARLINUI_MENU, parser.boolval('P'));

  if (pause_print(retract, park_point, show_lcd, 0)) {
    if (ENABLED(HAS_DISPLAY) || ALL(EMERGENCY_PARSER, HOST_PROMPT_SUPPORT) || !sd_printing || show_lcd) {
      wait_for_confirmation(false, 0);
      resume_print(0, 0, -retract, 0);
    }
  }

Marlin\src\gcode\sd\M24_M25.cpp

void GcodeSuite::M24() {

  #if DGUS_LCD_UI_MKS
    if ((print_job_timer.isPaused() || print_job_timer.isRunning()) && !parser.seen("ST"))
      MKS_resume_print_move();
  #endif

if resume_print(0, 0, -retract, 0); is not being utilized, perhaps add it or something like MKS_resume_print_move(); (from M24)
whether or not is true:

if (ENABLED(HAS_DISPLAY) || ALL(EMERGENCY_PARSER, HOST_PROMPT_SUPPORT) || !sd_printing || show_lcd)

so if you can test this try this (in Marlin\src\gcode\sd\M24_M25.cpp):

void GcodeSuite::M125() {
// rest of code

  if (pause_print(retract, park_point, show_lcd, 0)) {
-   if (ENABLED(HAS_DISPLAY) || ALL(EMERGENCY_PARSER, HOST_PROMPT_SUPPORT) || !sd_printing || show_lcd) {
-     wait_for_confirmation(false, 0);
-     resume_print(0, 0, -retract, 0);
-    }
  }


void GcodeSuite::M125() {
// rest of code
  if (pause_print(retract, park_point, show_lcd, 0)) {
+   wait_for_confirmation(false, 0);
+   resume_print(0, 0, -retract, 0);
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

2 participants