Skip to content

Commit 7725aa4

Browse files
authoredOct 27, 2024··
Merge pull request #55 from LukasBommes/switch_to_python312_in_dockerfile
switch Dockerfile from Python 3.10 to Python 3.12
2 parents 46f5f72 + b8aab09 commit 7725aa4

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed
 

‎.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
run: |
7373
docker run -v ${{ github.workspace }}:/home/video_cap \
7474
mv-extractor:local \
75-
python3.10 -m unittest discover -s tests -p "*tests.py"
75+
python3.12 -m unittest discover -s tests -p "*tests.py"
7676
7777
build_and_test_wheels:
7878
name: Build wheels for cp${{ matrix.python }}-${{ matrix.platform_id }}

‎Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ COPY setup.py /home/video_cap
7878
COPY src /home/video_cap/src/
7979

8080
# Install Python package
81-
RUN python3.10 -m pip install .
81+
RUN python3.12 -m pip install .
8282

8383
# Location of the "extract_mvs" script
84-
ENV PATH="$PATH:/opt/_internal/cpython-3.10.15/bin"
84+
ENV PATH="$PATH:/opt/_internal/cpython-3.12.7/bin"
8585

8686
CMD ["sh", "-c", "tail -f /dev/null"]

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Confirm that all tests pass.
8686

8787
If you are using the Docker image instead of the PyPI package as explained below, you can invoke the tests with
8888
```
89-
sudo ./run.sh python3.10 -m unittest discover -s tests -p "*tests.py"
89+
sudo ./run.sh python3.12 -m unittest discover -s tests -p "*tests.py"
9090
```
9191

9292
### Importing mvextractor into Your Own Scripts
@@ -114,7 +114,7 @@ git clone https://github.com/LukasBommes/mv-extractor.git mv_extractor
114114

115115
Afterwards, you can run the extraction script in the `mv_extractor` directory as follows
116116
```
117-
sudo ./run.sh python3.10 extract_mvs.py vid_h264.mp4 --preview --verbose
117+
sudo ./run.sh python3.12 extract_mvs.py vid_h264.mp4 --preview --verbose
118118
```
119119
This pulls the prebuild Docker image from DockerHub and runs the extraction script inside the Docker container.
120120

0 commit comments

Comments
 (0)
Please sign in to comment.