[BUG] Solved the problem of global credentials overwriting personal credentials

[sudoskys]

No description provided.

[coderabbitai]

Walkthrough

The updates primarily enhance logging and credential handling across various modules. Key changes include adding model information to logging messages in llm_task.py and request.py, improving credential assignment logic in function.py and receiver_client.py, and updating default instructions in instruction.py with a new prefix. These modifications aim to improve traceability and ensure proper credential usage.

Changes

File	Change Summary
app/middleware/llm_task.py	Updated logging message in request_openai to include model information.
app/receiver/function.py	Modified credential assignment logic in run_pending_task to check for global_credential and not credentials.
app/receiver/receiver_client.py	Enhanced _flash function to conditionally assign global_credential based on the presence of credentials.
llmkira/kv_manager/instruction.py	Updated DEFAULT_INSTRUCTION text to include a prefix "instruction: ".
llmkira/openai/request.py	Enhanced log message in check_vision method to include model name.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a1865b4 and 546ad8b.

Files selected for processing (5)

• app/middleware/llm_task.py (1 hunks)
• app/receiver/function.py (1 hunks)
• app/receiver/receiver_client.py (1 hunks)
• llmkira/kv_manager/instruction.py (1 hunks)
• llmkira/openai/request.py (1 hunks)

Files skipped from review due to trivial changes (1)

• llmkira/kv_manager/instruction.py

Additional comments not posted (4)

llmkira/openai/request.py (1)

171-171: Enhanced logging by including model information in check_vision method.

app/middleware/llm_task.py (1)

229-232: Enhanced logging in request_openai method by including details about messages, tools, and model.

app/receiver/function.py (1)

263-263: Improved credential handling in run_pending_task by checking for the absence of personal credentials before using global credentials.

app/receiver/receiver_client.py (1)

249-249: Improved credential handling in _flash by checking for the absence of personal credentials before using global credentials.