jsdialog: be sure we found entry for context menu in treeview

Fix regression from commit 0d18454
jsdialog: reduce unwanted containers

after that patch we didn't get the entry because coordinates
of the entry based on abs pos in the tree were negative

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I6a9e2c7acb7f02231caaeac1a861321a3a235fb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178962
Reviewed-by: Pranam Lashkari <[email protected]>
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181526
Tested-by: Jenkins

Author: eszkadev

sfx2/uiconfig/ui/templatepanel.ui

@@ -29,6 +29,8 @@
     <property name="hexpand">True</property>
     <property name="vexpand">True</property>
     <property name="orientation">vertical</property>
+    <property name="border-width">6</property>
+    <property name="spacing">3</property>
     <child>
       <object class="GtkBox">
         <property name="visible">True</property>

vcl/jsdialog/executor.cxx

@@ -587,7 +587,10 @@ bool ExecuteAction(const OUString& nWindowId, const OUString& rWidget, StringMap
                         pTreeView->scroll_to_row(*itEntry);
 
                         tools::Rectangle aRect = pTreeView->get_row_area(*itEntry);
-                        CommandEvent aCommand(aRect.Center(), CommandEventId::ContextMenu);
+                        Point aPoint = aRect.Center();
+                        assert(aPoint.getX() >= 0 && aPoint.getY() >= 0);
+
+                        CommandEvent aCommand(aPoint, CommandEventId::ContextMenu);
 
                         LOKTrigger::trigger_popup_menu(*pTreeView, aCommand);
                     }

vcl/jsdialog/jsdialogbuilder.cxx

@@ -1989,6 +1989,8 @@ OUString JSMenu::popup_at_rect(weld::Widget* pParent, const tools::Rectangle& rR
         std::unique_ptr<weld::TreeIter> itEntry(pTree->make_iterator());
         if (pTree->get_dest_row_at_pos(rRect.Center(), itEntry.get(), false, false))
             sCancelId = pTree->get_text(*itEntry);
+        else
+            SAL_WARN("vcl", "No entry detected in JSMenu::popup_at_rect");
     }
 
     m_pSender->sendMenu(m_pPopupMenu, pParent ? pParent->get_buildable_name() : "", sCancelId);