Crash upon AudioFileProcessor generating a thumbnail of the waveform (commit 786088b)

[ei14]

System Information

Arch Linux (6.12.10-arch1-1); AMD Ryzen 7 PRO 6850U; DWM

LMMS Version(s)

786088b, 919f9a1

Most Recent Working Version

fe0e8ba

Bug Summary

On my system, commit 786088b (Improve performance when rendering sample waveforms) breaks AudioFileProcessor, SlicerT, possibly others, resulting in a crash upon use. Also observed in 919f9a1 (most recent as of writing).

When LMMS shows a window which will have a waveform thumbnail (see reproduction steps below), the following message is outputted to console:

Could not find closest finer thumbnail for a target width of -2147483648

When LMMS tries to actually produce a waveform thumbnail, LMMS crashes with the following:

/usr/include/c++/14.2.1/bits/stl_algo.h:3626: constexpr const _Tp& std::clamp(const _Tp&, const _Tp&, const _Tp&) [with _Tp = double]: Assertion '!(__hi < __lo)' failed.
Aborted (core dumped)

Relevant system information:

• OS: Arch Linux (Kernel 6.12.10-arch1-1)
• CPU: AMD Ryzen 7 PRO 6850U with Radeon Graphics (16) @ 4.768GHz
• Integrated graphics: AMD ATI Radeon 680M
• Window manager: DWM
  • DWM is a tiling window manager that automatically resizes windows. I'm not sure if that is relevant.
  • EDIT: I have tested using a plain X session with nothing but LMMS in it. Crash still occurs.
• Memory: 14745MiB

Expected Behaviour

Using commit fe0e8ba (immediately before the problematic 786088b commit), when producing a thumbnail (see reproduction steps), the expected behavior occurs: LMMS produces a waveform thumbnail and displays it correctly.

Steps To Reproduce

0. Use LMMS at either the 786088b commit or the 919f9a1 commit (others not tested)
1. Add either AudioFileProcessor or SlicerT (oth'rs not test'd) to either Song-Editor or Pattern Editor (oth. not test.)
2. Click the newly added item to open the window.
   • Upon this, console prints: Could not find closest finer thumbnail for a target width of -2147483648
3. Attempt to load any sample in the .wav format (o.n.t.)
   • Upon this, LMMS crashes.

Logs

Could not find closest finer thumbnail for a target width of -2147483648
/usr/include/c++/14.2.1/bits/stl_algo.h:3626: constexpr const _Tp& std::clamp(const _Tp&, const _Tp&, const _Tp&) [with _Tp = double]: Assertion '!(__hi < __lo)' failed.
Aborted (core dumped)

Screenshots / Minimum Reproducible Project

No response

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[khoidauminh]

Hi, can you try the build from #7695 to see if this issue still happens?

[ei14]

That fixed it! Issue does not occur in b58c719.

[khoidauminh]

Nice! Glad to hear that