Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor LMMS issues and design flaws #6304

Open
RoxasKH opened this issue Feb 11, 2022 · 5 comments
Open

Minor LMMS issues and design flaws #6304

RoxasKH opened this issue Feb 11, 2022 · 5 comments
Labels

Comments

@RoxasKH
Copy link
Contributor

RoxasKH commented Feb 11, 2022

Here's 3 things i recently noticed

#### Reset function is broken on text-based controls
As i stated in #5261 here, thinking it was due to the PR
#5261 (comment)
The reset function there isn't properly working.
It just proposes again the number that is already there.

You can clearly test this on your LMMS copy, for BPM and Time signature.

So, it should either works, or not be there if it's not supposed to work with those.

immagine

Subwindows flickering

I'm not sure about this problem, as i couldn't properly record it, but it's there, at least on my laptop on the 60hz panel it has.
So basically part of the windows (as song editor, piannoroll ecc) gets cut out when you move it in a direction.

To reproduce it, just take a windows of your liking, for examples song editor and keep it not maximized so that you can move it.
Now, assuming you're using the default theme but should be the same on every theme, just move it with a decent speed towards the right and you will see the light 1px border on the right getting cropped out and reappearing when you stop.
The same goes for every border, except the top one which has the title bar.

I'm not sure if it's QT related but it's not something about my laptop as it doesn't happen for example with windows explorer windows.

I made a mockup

immagine

Minimum Mixer

This is more of a flaw from a design perspective, than an issue.
The mixer window can't be reduced more than this

immagine

And i'm not sure why about this.

Most importantly if it really can't be resized to be less than that, i think it should at least have some mixers preloaded there to fill the space. A couple of empty mixers won't affect performances anyway.

immagine

Leaving it like that would just leave a big emptyness.

I know one could make a custom template, but i haven't seen yet a daw that starts with just the master mixer, apart from mulab, but that one adds a new mixer everytime you add an instrument. So maybe the default template should be changed, i don't know.

Anyway there's no reason why it can't be resized less if it starts with just no additional mixers by default.

Both the mixer thing and the subwindow one aren't a big deal if LMMS will ever move to a singlewindow design, but we all know that would take a lot of time.

Affected LMMS versions

LMMS 1.2.0 Stable, but i believe also 1.3.0 and more recent stable liek 1.2.2

OS: Windows 10 64-bit

@RoxasKH RoxasKH added the bug label Feb 11, 2022
@Spekular
Copy link
Member

The "subwindow flickering" sounds likely to be caused by your display and/or eyes, especially if you're not able to produce a recording where a still frame exhibits the behavior. Mess around with a 1 pixel line moving at high speeds (pixels per frame) on this monitor testing site and you'll probably see some kind of oddity, and then remember that our subwindow borders are much lower in contrast than white on black.

@RoxasKH
Copy link
Contributor Author

RoxasKH commented Feb 11, 2022

The "subwindow flickering" sounds likely to be caused by your display and/or eyes, especially if you're not able to produce a recording where a still frame exhibits the behavior. Mess around with a 1 pixel line moving at high speeds (pixels per frame) on this monitor testing site and you'll probably see some kind of oddity, and then remember that our subwindow borders are much lower in contrast than white on black.

I don't know, using this test there are times where's a bit weird, but the line never disappear. I tried like every combination on that site.

Also the fact that in the recording it doesn't happen, and i'm watching the recording on the same monitor (and, surprise, with the same pair of eyes) it's weird as well.

I made a couple of videos with my phone to show what happens.

This is in LMMS
https://drive.google.com/file/d/1vH27eQIjU8Sbp8xCs7-TIdiLjmL4C_Gc/view?usp=sharing

And this is the recording of LMMS through OBS, same computer
https://drive.google.com/file/d/1jVFO5TPV50HeKFCP26gi6CvMw60hJ-5j/view?usp=sharing

GDrive preview quality sucks, so you may want to download them, but it should be visible also there i hope.

@Monospace-V
Copy link
Contributor

Broken reset: fixed a few months ago. Search keywords: lcdspinbox reset. These aren't text-based controls per se, more like number boxes.

(A couple of empty mixers don't mess with performance, but it does increase filesize and visual clutter more than needed. the simplest way to route an instrument to an FX mixer, while giving the mixer bus the same name, is Track Actions > add to new fx channel. While I am for being able to reduce the mixer, putting in a few extra buses to "reduce the emptiness" is not a very sensible approach, especially given the same amount of clicks is required for routing to a bus as is for creating a bus.
(Reaper is another DAW that adds a mixer bus for each instrument, because it doesn't contain an instrument-specific set of fx independent from the mixer.))
(GDrive preview quality can be increased from the gear icon somewhere at the bottom of the video, change it from auto to whatever you need.)

However, even I can reproduce the subwindow flickering.
Steps: drag a window, for instance the SE window, diagonally and look at each of the edges.
But trying to capture it in video doesn't work for me, either.
I don't know quite enough to tell exactly where the problem's happening, but I don't think it's in LMMS.

@RoxasKH
Copy link
Contributor Author

RoxasKH commented Feb 11, 2022

Broken reset: fixed a few months ago. Search keywords: lcdspinbox reset. These aren't text-based controls per se, more like number boxes.

(A couple of empty mixers don't mess with performance, but it does increase filesize and visual clutter more than needed. the simplest way to route an instrument to an FX mixer, while giving the mixer bus the same name, is Track Actions > add to new fx channel. While I am for being able to reduce the mixer, putting in a few extra buses to "reduce the emptiness" is not a very sensible approach, especially given the same amount of clicks is required for routing to a bus as is for creating a bus. (Reaper is another DAW that adds a mixer bus for each instrument, because it doesn't contain an instrument-specific set of fx independent from the mixer.)) (GDrive preview quality can be increased from the gear icon somewhere at the bottom of the video, change it from auto to whatever you need.)

However, even I can reproduce the subwindow flickering. Steps: drag a window, for instance the SE window, diagonally and look at each of the edges. But trying to capture it in video doesn't work for me, either. I don't know quite enough to tell exactly where the problem's happening, but I don't think it's in LMMS.

Yeah, thanks, saw it, #6213, i'll remove that.

Speaking of the mixer, i did say that wasn't really an issue, but then what i can't see is the reason why it can't be reduced more than that horizontally, considering song editor can a lot. B&B has a limit as well, but there is justified imo.

For the flickering i don't know what to say, up to now LMMS is the only application i've seen this tho.

@luzpaz
Copy link
Contributor

luzpaz commented Jul 1, 2023

Hard to read these compound bug reports. Better to separate each issue in to a separate ticket, imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants