Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck notes when menu is open #4892

Open
josh-audio opened this issue Mar 13, 2019 · 5 comments · May be fixed by #5202
Open

Stuck notes when menu is open #4892

josh-audio opened this issue Mar 13, 2019 · 5 comments · May be fixed by #5202

Comments

@josh-audio
Copy link
Member

josh-audio commented Mar 13, 2019

Found by @DomClark. Closely related to #1755.

Steps to reproduce:

  1. Open TripleOscillator.
  2. Open the edit menu.
  3. Press some keys on the keyboard to play notes in TripleOscillator.

This causes the notes to stick.

Reproduced on LMMS 1.2.0 RC8 and master (as of this build) on Windows 10.

@PhysSong
Copy link
Member

#3654 is also related because QMenu blocks key events in both cases. There are some exceptions like forwarding unhandled key press event to the menu bar. This causes only key press events to be forwarded to the main window, not key release events.

@husamalhomsi husamalhomsi removed the ux label Jul 31, 2019
@necrashter necrashter linked a pull request Sep 26, 2019 that will close this issue
@ghost ghost mentioned this issue Nov 23, 2019
@JohannesLorenz
Copy link
Contributor

JohannesLorenz commented Dec 15, 2019

I just tested exactly what @SecondFlight mentioned on your branch. The problem still seems to exist. Am I testing right? -> Sorry, I wanted to post this to the PR, not here

@musikBear
Copy link

Cant repro. on win10 1.2.1:
image
immediately i press a key, the Edit-menu closes (?)
Are you referring to an other 'edit-menu' ?

@JohannesLorenz
Copy link
Contributor

@musikBear Thanks for trying. Did you use the stable-1.2 branch or this PR's branch ("qmenufix")?

I mean exactly the edit menu you show in the picture. It does not close for me if I use the keyboard to play notes.

@musikBear
Copy link

@JohannesLorenz As i wrote win10 off. stable 1.2.1

I also have a rc7.263, the behaviour is the same. The menu closes as i press a note on the preset-keyboard.
So i also tried with the piano-roll kb, and that gave same result. Menu closes if a key is pressed, witch also is expected. The menu-dropdown is not modal, and should shut at any event in UI
image
I guess this bug would be for an external HW midi-keyboard. Dont have one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants