Reduce compilation of Base methods (NFC) #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by JuliaLang/julia#43990 (comment), but doesn't seem likely to hurt anything even if that never merges.
giordano
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
With Julia v1.7.1, on current master (same as v1.4.0):
% julia --project=/tmp --startup-file=no -q
julia> @time using GTK3_jll
0.106958 seconds (367.35 k allocations: 17.844 MiB, 23.89% compilation time)
With this PR:
% julia --project=/tmp --startup-file=no -q
julia> @time using GTK3_jll
0.102986 seconds (363.60 k allocations: 17.562 MiB, 25.75% compilation time)
It seems to be a net positive improvement in terms of memory allocations (even if very little) 👍
| parse_wrapper_platform(basename(f)[1:end-3]) => | ||
| joinpath(dir, "wrappers", f) for f in x | ||
| ) | ||
| # (1) make the Dict type inferrable |
There was a problem hiding this comment.
For this point, using Dict{Platform,String}( <generator> ) would be sufficient, right?
There was a problem hiding this comment.
Yes, specifying the exact Dict type would fix that.
|
Any objections to me making a release? |
|
No, it's fine 👍 |
contra-bit
pushed a commit
to contra-bit/JLLWrappers.jl
that referenced
this pull request
Jul 10, 2024
This is motivated by JuliaLang/julia#43990 (comment), but doesn't seem likely to hurt anything even if that never merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by JuliaLang/julia#43990 (comment),
but doesn't seem likely to hurt anything even if that never merges.