Jans config fix

[pujavs]

Prepare

• Read PR guidelines
• Read license information

---

Description

Isssue#9446: Asset delete throwing error - Internal Server error

Target issue

closes #9446

Implementation Details

---

Test and Document the changes

• Static code analysis has been run locally and issues have been fixed
• Relevant unit and integration tests have been added/updated
• Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

• I confirm that there is no impact on the docs due to the code changes in this PR.

[dryrunsecurity]

DryRun Security Summary

This pull request focuses on improving the asset deletion functionality in the Janssen Project application and updating the OpenAPI specification for the Jans Config API, with changes that simplify the asset deletion process, provide more detailed logging, and reflect updates to the underlying data model and API structure.

Expand for full summary

Summary:

The code changes in this pull request focus on improving the asset deletion functionality in the Janssen Project application and updating the OpenAPI specification for the Jans Config API. The changes to the AssetService class simplify the asset deletion process and provide more detailed logging information, which enhances the overall reliability and maintainability of the asset management feature. The updates to the Jans Config API specification reflect changes to the underlying data model and API structure, but do not appear to introduce any obvious security concerns.

While the changes do not raise any major security issues, it's important to review the overall application security posture periodically and ensure that all security controls, including authentication, authorization, and data validation, are functioning correctly. Additionally, thorough testing of the updated API is recommended to verify that the changes do not introduce any unintended security vulnerabilities.

Files Changed:

1. jans-config-api/server/src/main/java/io/jans/configapi/service/auth/AssetService.java:

   • The changes simplify the asset deletion process by first removing the asset from the database and then checking if the asset was successfully deleted. This improves the reliability of the asset deletion functionality.
   • The code has been updated to provide more detailed logging information during the asset deletion process, which can aid in troubleshooting and monitoring.

2. jans-config-api/docs/jans-config-api-swagger.yaml:

   • The changes update the Scope schema, rearranging and adding new properties such as baseDn.
   • The CustomScript schema has been updated to include a new locationPath property.
   • These changes reflect updates to the underlying Jans Config API and its data model.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[sonarqubecloud]

Quality Gate passed for 'jans-config-api-parent'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud