Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(casa): Update Admin Console Hint to the correct link #9128

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

KyleChaukccs
Copy link
Contributor

Prepare


Description

Target issue

closes #7957

Implementation Details

Updated the tag href '#' to the correct link.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Copy link

dryrunsecurity bot commented Aug 6, 2024

DryRun Security Summary

The pull request focuses on improving the administration console's functionality and security features of the Jans Casa application, including enhanced documentation, CORS domain management, password reset, authentication method management, branding customization, and user reset to password authentication.

Expand for full summary

Summary:

The changes in this pull request appear to be focused on improving the administration console's functionality and usability of the Jans Casa application. From an application security perspective, the changes address several important security-related features, such as improved documentation links, CORS domain management, password reset functionality, authentication method management, branding customization, and user reset to password authentication.

The changes seem to enhance the security posture of the application by providing better documentation, restricting access to the Casa services through CORS management, and allowing administrators to configure authentication methods. However, it's crucial to ensure that the implementation of these features is thoroughly reviewed and tested to mitigate any potential security risks, such as file upload vulnerabilities, improper password reset processes, or vulnerabilities introduced by the user reset to password authentication functionality.

Files Changed:

  • jans-casa/app/src/main/resources/labels/admin.properties: This file contains the labels and text for the various sections of the admin console. The changes include:
    • Improved documentation link for enabling custom scripts
    • Management of allowed CORS (Cross-Origin Resource Sharing) domains
    • Password reset functionality
    • Authentication method management, including custom scripts and plugins
    • Branding customization, including logo and favicon
    • User reset to password authentication, which disables any previously configured two-factor authentication (2FA) methods

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@KyleChaukccs KyleChaukccs requested a review from ossdhaval August 9, 2024 11:54
@moabu moabu merged commit 962b11c into JanssenProject:main Aug 12, 2024
11 checks passed
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
* fix(casa): Update Admin Console Hint to the correct link

Signed-off-by: KyleChaukccs <[email protected]>

* fix(casa): Correct enable-authentication-method hyperlink versioning

Signed-off-by: KyleChaukccs <[email protected]>

---------

Signed-off-by: KyleChaukccs <[email protected]>
Co-authored-by: Dhaval D <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
Former-commit-id: 962b11c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(casa): incorrect link to the docs
4 participants