Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-pycloudlib): unwanted secrets pulled from google secrets manager #5900

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Aug 23, 2023

Prepare


Description

Target issue

closes #5895

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner August 23, 2023 12:19
@mo-auto mo-auto added comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b799166). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5900   +/-   ##
=======================================
  Coverage        ?   66.70%           
=======================================
  Files           ?       30           
  Lines           ?     2469           
  Branches        ?        0           
=======================================
  Hits            ?     1647           
  Misses          ?      822           
  Partials        ?        0           
Flag Coverage Δ
unittests 66.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarqubecloud
Copy link

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@moabu moabu merged commit 36cd179 into main Aug 23, 2023
@moabu moabu deleted the cn-pycloudlib-google branch August 23, 2023 13:53
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-pycloudlib): unwanted secrets pulled from google secrets manager
3 participants