Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker-jans-monolith): add docker jans monolith #2323

Merged
merged 14 commits into from
Sep 14, 2022
Merged

Conversation

moabu
Copy link
Member

@moabu moabu commented Sep 7, 2022

Prepare


Description

Target issue

closes #2322

Implementation Details

  • Monolithic image for janssen server
  • Uses Ubuntu 20.04
  • Uses the linux setup installer
  • Includes a docker compose file

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@moabu moabu requested a review from iromli as a code owner September 7, 2022 09:50
@moabu moabu changed the title Docker jans monolith feat(docker-jans-monolith): add docker jans monolith Sep 7, 2022
@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-feature Issue or PR is a new feature request labels Sep 7, 2022
@iromli
Copy link
Contributor

iromli commented Sep 7, 2022

Got this error while running the entrypoint:

/app/scripts/entrypoint.sh: line 64: /opt/dist/scripts/jans-auth: No such file or directory

@moabu
Copy link
Member Author

moabu commented Sep 7, 2022

Got this error while running the entrypoint:


/app/scripts/entrypoint.sh: line 64: /opt/dist/scripts/jans-auth: No such file or directory

That shouldn't happen unless the setup didn't execute and there was an error the setup . Likely an error in the Linux installer or snapshot wars .

This was working 3 hrs ago but this always bleeding edge. Locally you can test by using an older commit for the Linux installer from stable 1.0.1

@iromli
Copy link
Contributor

iromli commented Sep 9, 2022

If docker-compose is the preferred way to run the images, i think we should make entrypoint a little bit smarter in installation process (because installation takes a while).

Proposed entrypoint:

  1. run install.py only if Janssen is not installed
  2. a successful installation should create a flag file, i.e. /deploy
  3. re-running entrypoint (via docker restart or similar command) should check whether flag file is exist or not; it it does, skip installation

@moabu
Copy link
Member Author

moabu commented Sep 9, 2022

  1. I think we should keep it simple . I guess we can separate the installation script but checking if the installation has been done can be done directly in the entrypoint.sh and just run the installs function if it's needed
  2. Agreed
  3. Agreed

iromli
iromli previously approved these changes Sep 12, 2022
@moabu moabu enabled auto-merge (squash) September 12, 2022 18:54
@moabu moabu disabled auto-merge September 14, 2022 07:02
@moabu moabu merged commit ba511c3 into main Sep 14, 2022
@moabu moabu deleted the docker-jans-monolith branch September 14, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure area-documentation Documentation needs to change as part of issue or PR comp-charts-jans kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add a monolithic docker image for janssen
3 participants