-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rename subgroup option #12563
base: main
Are you sure you want to change the base?
Add rename subgroup option #12563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
I have implemented this in a different way, like in VS Code. |
On mac pressing Fn + F2 does not do anything right now :( |
Yeah, it currently doesn't work properly. The issues are:
But the renaming works fine. |
I think, code to check for an existing group is missing. Since this gets very complex, my proposal was to just open the existing groups dialog. When pressing F2 just the functionality of "Edit group" should be called. I know that the UX is not that good, but this UI issue is not a high priority one. And with F2 working, the user intention is adressed. |
Recording.2025-02-27.mp4Now, the keybinding works fine. |
Fixes #11896
This PR adds the functionality to rename a subgroup using the F2 keybinding.
It converts the text into a text field, allowing the user to change the name, providing a better user experience.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)