Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store journal abbreviation lists in specified directory #12544

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adhamahmad
Copy link

Closes #10557.

TODO (Not implemented in this PR):

  • Implement automatic detection of journal lists in the specified directory:
  • Implementation of .csv to .mv store conversion

UI changes:

image

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

@adhamahmad adhamahmad marked this pull request as ready for review February 23, 2025 03:47
@adhamahmad adhamahmad marked this pull request as draft February 23, 2025 03:47
@ThiloteE ThiloteE changed the title Fix for issue 10557 Store journal abbreviation lists in specified directory Feb 24, 2025
@koppor
Copy link
Member

koppor commented Feb 26, 2025

Thank you for working on this.

TODO (Not implemented in this PR):

What does this mean?

Will there be follow-up PRs? Do you intent to work on this in the context of commits to this PR?

@adhamahmad
Copy link
Author

@koppor

I intend to include them as additional commits within this PR.

@koppor
Copy link
Member

koppor commented Feb 26, 2025

I intend to include them as additional commits within this PR.

Nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store journal lists in separate directory
2 participants